public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Aaron Rainbolt <arainbolt@kfocus.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Mario Limonciello <mario.limonciello@amd.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	lenb@kernel.org, mmikowski@kfocus.org, Perry.Yuan@amd.com,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH V3] acpi: Allow ignoring _OSC CPPC v2 bit via kernel parameter
Date: Wed, 19 Jun 2024 20:05:25 -0500	[thread overview]
Message-ID: <ZnOAVWdBanvocb4D@kf-XE> (raw)
In-Reply-To: <ZnNZgxDaXoCqkkJq@kf-XE>

OK, we have done thorough benchmarking of the two patches. In summary,
they both seem to provide exactly the same performance improvements.
My initial worry that Rafael's patch didn't deliver the same performance
improvements was unfounded.

The following are the single-core and multi-core scores from running
Geekbench 5 multiple times on a Carbon Systems Iridium 16 system. The
first batch of tests was done with an Ubuntu kernel built with with my V3
proposed patch, while the second batch was done with a kernel build with
Rafael's proposed patch.

Links to the Geekbench 5 reports can be shared if needed.

_OSC CPPC bit ignore patch (written by Aaron Rainbolt):
Kernel parameter 'ignore_osc_cppc_bit' set in
'/etc/default/grub.d/kfocus.cfg'.
'/sys/devices/system/cpu/cpu*/acpi_cppc' and
'/proc/sys/kernel/sched_itmt_enabled' both present

| Run | Single | Multi  |
| --- | ------ | ------ |
|  01 |   1874 |  10475 |
|  02 |   1831 |  10132 |
|  03 |   1858 |  10348 |
|  04 |   1848 |  10370 |
|  05 |   1831 |  10413 |
| --- | ------ | ------ |
| AVG |   1848 |  10348 |


intel_pstate CPPC override patch (written by Rafael Wysocki):
No special kernel parameters set.
'/sys/devices/system/cpu/cpu*/acpi_cppc' ABSENT,
'/proc/sys/kernel/sched_itmt_enabled' present

| Run | Single | Multi  |
| --- | ------ | ------ |
|  01 |   1820 |  10310 |
|  02 |   1870 |  10303 |
|  03 |   1867 |  10420 |
|  04 |   1844 |  10283 |
|  05 |   1835 |  10451 |
| --- | ------ | ------ |
| AVG |   1847 |  10353 |

  reply	other threads:[~2024-06-20  1:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  2:54 [PATCH] acpi: Allow ignoring _OSC CPPC v2 bit via kernel parameter Aaron Rainbolt
2024-06-18 17:09 ` Mario Limonciello
2024-06-18 18:30   ` Aaron Rainbolt
2024-06-18 18:35     ` Mario Limonciello
2024-06-18 18:52       ` Aaron Rainbolt
2024-06-18 18:58         ` Mario Limonciello
2024-06-18 19:25           ` Aaron Rainbolt
2024-06-18 19:27             ` Mario Limonciello
2024-06-18 20:25               ` [PATCH V2 RFC] " Aaron Rainbolt
2024-06-18 20:58                 ` Aaron Rainbolt
2024-06-18 21:24                 ` Mario Limonciello
2024-06-18 21:47                   ` Aaron Rainbolt
2024-06-19  4:33                     ` [PATCH V3] " Aaron Rainbolt
2024-06-19  5:08                       ` Mario Limonciello
2024-06-19 17:09                       ` Rafael J. Wysocki
2024-06-19 17:30                         ` Rafael J. Wysocki
2024-06-19 17:44                           ` Aaron Rainbolt
2024-06-19 17:56                           ` Aaron Rainbolt
2024-06-19 21:39                           ` Aaron Rainbolt
2024-06-19 22:19                             ` Aaron Rainbolt
2024-06-20  1:05                               ` Aaron Rainbolt [this message]
2024-06-20 15:40                                 ` Rafael J. Wysocki
2024-06-19 17:34                         ` Aaron Rainbolt
2024-06-19 17:37                           ` Rafael J. Wysocki
2024-06-18 18:31 ` [PATCH] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnOAVWdBanvocb4D@kf-XE \
    --to=arainbolt@kfocus.org \
    --cc=Perry.Yuan@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mmikowski@kfocus.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox