From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO
Date: Wed, 14 Aug 2024 23:09:51 +0300 [thread overview]
Message-ID: <Zr0PD5d2bqpikxf_@smile.fi.intel.com> (raw)
In-Reply-To: <20240814190159.15650-1-hdegoede@redhat.com>
On Wed, Aug 14, 2024 at 09:01:56PM +0200, Hans de Goede wrote:
> Hi Rafael,
>
> 6.10 has a new backlight driver for UART attached backlight controller
> boards found in some Dell All in One models.
>
> Now the first AIO has turned up which has not only the DSDT bits for this,
> but also an actual controller attached to the UART, yet it is not using
> this controller for backlight control (it needs GPU native control).
>
> I did not tie the dell-uart-backlight into acpi_video_get_backlight_type()
> yet, so the first 2 patches in this series deal with that and the third
> patch adds a DMI quirk to select native backlight control on top.
>
> Backlight control used to work on the Dell OptiPlex 7760 AIO with kernel
> 6.9 and older, so this is a regression and I would like to see this
> series merged as fixes for 6.11.
>
> Rafael, the drivers/platform/x86/dell/dell-uart-backlight.c are small
> and isolated. So I believe it is best if you take the entire series,
> to avoid conflicts if any other drivers/apci/video_detect.c DMI quirks
> show up this cycle.
FWIW,
Reviewed-by: Andy Shevchenko <andy@kernel.org>
I find this quite small and I agree this would be nice to have as fixes.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-14 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 19:01 [PATCH 0/3] ACPI/video / platform/x86: Add backlight=native quirk for Dell OptiPlex 7760 AIO Hans de Goede
2024-08-14 19:01 ` [PATCH 1/3] ACPI: video: Add Dell UART backlight controller detection Hans de Goede
2024-08-14 19:01 ` [PATCH 2/3] platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type() Hans de Goede
2024-08-14 19:01 ` [PATCH 3/3] ACPI: video: Add backlight=native quirk for Dell OptiPlex 7760 AIO Hans de Goede
2024-08-14 20:09 ` Andy Shevchenko [this message]
2024-08-19 13:59 ` [PATCH 0/3] ACPI/video / platform/x86: " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr0PD5d2bqpikxf_@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox