From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C69525634 for ; Thu, 8 Aug 2024 08:46:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723106810; cv=none; b=soLOsYaN6/fR3g11xB3YjWLXQv89PvIA5QKsuVbBqhyqk8racekwn/kIxwbHVIH1ti3QjtLPT9KYtJxs4PP7CopliW/qEuowq2GZSLCIEtxffkOm+tqEs5FWZAYH61fksRRPJkUESpJib0N6TthuCnVLDhcgYY97cY4upez8m20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723106810; c=relaxed/simple; bh=Vb9+V5rKj1QNZHb+8cAwnjuUwgrtuyBCac+ywYJJXVE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=giZ43QWBXPe1MJhgraObeXpYF1yjPpaqeHAyAWUL7myCZrTCagl5IWTOfTqQVEdeneW8nFGeC6l5wCQGbsEKNJB2X+5cb1QInpmOAXolQYrQArHx1JhpW9o7wILE8iWjtK2rZU83LK2YCQpsAg0dvSP/iEnIBckWKebwCDIzito= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 887BCFEC; Thu, 8 Aug 2024 01:47:13 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE2423F71E; Thu, 8 Aug 2024 01:46:46 -0700 (PDT) Date: Thu, 8 Aug 2024 09:46:44 +0100 From: Sudeep Holla To: shankerwangmiao@gmail.com Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Sunil V L , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ACPI: introduce acpi_arch_init Message-ID: References: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com> On Wed, Aug 07, 2024 at 02:36:12PM +0800, Miao Wang via B4 Relay wrote: > From: Miao Wang > > To avoid arch-specific code in general ACPI initialization flow, > we introduce a weak symbol acpi_arch_init. Currently, arm64 can > utillize this to insert its specific flow. In the future, > other architectures can also have chance to define their own > arch-specific acpi initialization process if necessary. > > Signed-off-by: Miao Wang > --- > Changes from v1 > - Change acpi_arch_init from a static inline stub to a weak function > according to Haijun Guo's advice > --- > drivers/acpi/arm64/init.c | 2 +- > drivers/acpi/bus.c | 4 +++- > include/linux/acpi.h | 6 +----- > 3 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/arm64/init.c b/drivers/acpi/arm64/init.c > index d0c8aed90fd1..7a47d8095a7d 100644 > --- a/drivers/acpi/arm64/init.c > +++ b/drivers/acpi/arm64/init.c > @@ -2,7 +2,7 @@ > #include > #include "init.h" > > -void __init acpi_arm_init(void) > +void __init acpi_arch_init(void) > { > if (IS_ENABLED(CONFIG_ACPI_AGDI)) > acpi_agdi_init(); > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 284bc2e03580..b47541e45a5a 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -1431,6 +1431,8 @@ static int __init acpi_bus_init(void) > struct kobject *acpi_kobj; > EXPORT_SYMBOL_GPL(acpi_kobj); > > +void __weak acpi_arch_init(void) { } > + Why is __init dropped or not needed above ? Otherwise looks good. With the above __init fixed, you can add Reviewed-by: Sudeep Holla -- Regards, Sudeep