public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Sanket Goswami <Sanket.Goswami@amd.com>
Subject: Re: [PATCH v1] ACPI: APD: Add AMDI0015 as platform device
Date: Fri, 9 Aug 2024 18:59:35 +0300	[thread overview]
Message-ID: <ZrY854CyoKwQfQXi@smile.fi.intel.com> (raw)
In-Reply-To: <7c550151-39a8-4155-ae9e-4796d9463cd4@amd.com>

On Fri, Aug 09, 2024 at 09:08:22PM +0530, Shyam Sundar S K wrote:
> +Andy
> 
> On 7/18/2024 20:53, Shyam Sundar S K wrote:
> > Add AMDI0015 to the ACPI APD support list to ensure correct clock settings
> > for the I3C device on the latest AMD platforms.

...

> >  	{ "AMD0040", APD_ADDR(fch_misc_desc)},
> >  	{ "AMDI0010", APD_ADDR(wt_i2c_desc) },
> >  	{ "AMDI0019", APD_ADDR(wt_i2c_desc) },
> > +	{ "AMDI0015", APD_ADDR(wt_i3c_desc) },

Please, keep it sorted.

...

> FYI..

Thanks!

> AMDI0015 is for MIPI I3C (we call it I3C legacy) version of the
> implementation.
> 
> and.. MIPI0100 is for HCI based implementation of the MIPI I3C
> Specification.

This is fine as long as there is no collision, i.e. if a new (HCI I3C _HID is
required the new one should be allocated).

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2024-08-09 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 15:23 [PATCH v1] ACPI: APD: Add AMDI0015 as platform device Shyam Sundar S K
2024-08-09 15:38 ` Shyam Sundar S K
2024-08-09 15:59   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrY854CyoKwQfQXi@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Sanket.Goswami@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox