Re: [PATCH 2/8] x86/amd: Rename amd_get_highest_perf() to amd_get_boost_ratio_numerator()

kernel test robot
2024-08-28T09:09:51Z

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge tip/x86/core tip/master linus/master v6.11-rc5 next-20240827]
[cannot apply to tip/auto-latest]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/x86-amd-Move-amd_get_highest_perf-from-amd-c-to-cppc-c/20240827-051648
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240826211358.2694603-3-superm1%40kernel.org
patch subject: [PATCH 2/8] x86/amd: Rename amd_get_highest_perf() to amd_get_boost_ratio_numerator()
config: x86_64-randconfig-074-20240828 (https://download.01.org/0day-ci/archive/20240828/202408281637.ssIOSO7H-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240828/202408281637.ssIOSO7H-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408281637.ssIOSO7H-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/kernel/acpi/cppc.c:133:5: error: redefinition of 'amd_get_boost_ratio_numerator'
133 | int amd_get_boost_ratio_numerator(unsigned int cpu, u64 *numerator)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/x86/kernel/acpi/cppc.c:7:
include/acpi/cppc_acpi.h:142:19: note: previous definition of 'amd_get_boost_ratio_numerator' with type 'int(unsigned int, u64 *)' {aka 'int(unsigned int, long long unsigned int *)'}
142 | static inline int amd_get_boost_ratio_numerator(unsigned int cpu, u64 *numerator) { return -ENODEV; }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/amd_get_boost_ratio_numerator +133 arch/x86/kernel/acpi/cppc.c

121
122 /**
123 * amd_get_boost_ratio_numerator: Get the numerator to use for boost ratio calculation
124 * @cpu: CPU to get numerator for.
125 * @numerator: Output variable for numerator.
126 *
127 * Determine the numerator to use for calculating the boost ratio on
128 * a CPU. On systems that support preferred cores, this will be a hardcoded
129 * value. On other systems this will the highest performance register value.
130 *
131 * Return: 0 for success, negative error code otherwise.
132 */
> 133 int amd_get_boost_ratio_numerator(unsigned int cpu, u64 *numerator)

--
0-DAY CI Kernel Test Service