From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 707B71B0132 for ; Thu, 29 Aug 2024 16:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724947250; cv=none; b=HIvqNQEHfIMVJFwQENugaSJZ+UVPH0oLuHDFVUhKoZboRgsn6v3WDVK0Y728ryCK7+A1VYjBgm43Oqww/sH1VUT7KwTkIw8bNIHi62+YaYBFZV3LjCEKBMPEZqLD7JyhYv/oGSMP3NrfzBiv7q6IzAtsZLD4MvTP5sMuQi0vaOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724947250; c=relaxed/simple; bh=kpID/AnHT689tbVWJHhcVpCsjLAWu+om2tQs+xG4GkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kIidhvrFn65zieFl0cjTR/lQiD2EyvS14FGZFmNXCkuS2Lttjqo7ENAW4hPbingULPHwxfc6Wmo1ryFNCwQixuQIlqr7wwiZvbkvJFHAvOFxULxYKwzULMHArdvAOu22HOu3YPHoNYQJQ5SZpvSAHQgbsLJKs+jEx+Kp1VJt7Kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D98C3DA7; Thu, 29 Aug 2024 09:01:13 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9876F3F762; Thu, 29 Aug 2024 09:00:46 -0700 (PDT) Date: Thu, 29 Aug 2024 17:00:44 +0100 From: Sudeep Holla To: Miao Wang Cc: Hanjun Guo , "Rafael J. Wysocki" , Len Brown , Sunil V L , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] ACPI: introduce acpi_arch_init Message-ID: References: <20240808-intro-acpi-arch-init-v3-1-ba510859baff@gmail.com> <64bd9991-61a9-5cb5-60fe-941cb4171290@huawei.com> <4EC8AF0D-321F-437B-93C6-E597E4D4BB34@gmail.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4EC8AF0D-321F-437B-93C6-E597E4D4BB34@gmail.com> On Wed, Aug 28, 2024 at 04:40:29AM +0800, Miao Wang wrote: > > > > 2024年8月8日 17:43，Hanjun Guo 写道： > > > > On 2024/8/8 17:00, Miao Wang via B4 Relay wrote: > >> From: Miao Wang > >> To avoid arch-specific code in general ACPI initialization flow, > >> we introduce a weak symbol acpi_arch_init. Currently, arm64 can > >> utillize this to insert its specific flow. In the future, > >> other architectures can also have chance to define their own > >> arch-specific acpi initialization process if necessary. > >> Signed-off-by: Miao Wang > >> Reviewed-by: Sunil V L > >> Reviewed-by: Sudeep Holla > >> --- > >> Changes from v1 > >> - Change acpi_arch_init from a static inline stub to a weak function > >> according to Haijun Guo's advice > >> --- > >> Changes from v2: > >> - Add __init attribute to the weak acpi_arch_init stub > >> - Link to v2: https://lore.kernel.org/r/20240807-intro-acpi-arch-init-v2-1-9231e23a7721@gmail.com > > > > Thanks for the quick update, > > > > Acked-by: Hanjun Guo > > Hi, all. I wonder whether this patch is good to be applied or > any improvement is needed. > LGTM. Rafael, do you want to take this via your tree or arm64(need your ack) once you are happy with the change ? -- Regards, Sudeep