From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B19551B0117; Thu, 29 Aug 2024 16:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724948689; cv=none; b=lI4dkRsnaO1zJjzt1r8Zs2GInkgwjuIk0G5IA0S4mJQVGql9L3KOMU0ZN8evJDBxLdsTdMPMMIsNdAhdcz96L7G/T5QmCILX26g/psgkqUvawaYJ4fyUNwJMAeMhLbLt2lak4coZ/4/RdBuocAZoT6lFT34eF6oxKqoIJ++b0z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724948689; c=relaxed/simple; bh=8xb0icPtltMAc+V6b/uJsv3r2//xNmKDMQYZoNJARcc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vz857mHUuI+2iXhYwtbDrSCwDIZfB+ED2xfatSxZzJFjxfunWVvB1RLslC7BqI4XZPah4yPyXOtHl6r+VB30X9sidq/qGDu3+oJtbeTPo7AS29ajdqYHuW//Auhk8/1U67PxbtHTiOj7LMlxmoZF2jMzR0sUQ9pFUMbxUP/6uE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30F81106F; Thu, 29 Aug 2024 09:25:13 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 387293F762; Thu, 29 Aug 2024 09:24:45 -0700 (PDT) Date: Thu, 29 Aug 2024 17:24:42 +0100 From: Sudeep Holla To: Aleksandr Mishin Cc: Fu Wei , Lorenzo Pieralisi , Hanjun Guo , "Rafael J. Wysocki" , Len Brown , Mark Rutland , , , , Subject: Re: [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block() Message-ID: References: <20240827101239.22020-1-amishin@t-argos.ru> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 29, 2024 at 05:17:44PM +0100, Sudeep Holla wrote: > On Tue, Aug 27, 2024 at 01:12:39PM +0300, Aleksandr Mishin wrote: > > In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame' > > will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block > > because do{} block will be executed even if 'i == 0'. > > > > Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > (For some reason I don't see the original email in my inbox, might have > got blocked 🙁). Anyways LGTM, > > Acked-by: Aleksandr Mishin Sorry I messed up, I meant Acked-by: Sudeep Holla -- Regards, Sudeep