[PATCH 1/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller

[PATCH 1/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller

[hunter.yu]

From: "hunter.yu" <hunter.yu@hj-micro.com>

I2C clock frequency for HJMC01 is 200M, define a new ACPI
HID for it.

Signed-off-by: hunter.yu <hunter.yu@hj-micro.com>
---
 drivers/acpi/acpi_apd.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index 800f97868448..bc271d1cb31b 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -181,6 +181,11 @@ static const struct apd_device_desc hip08_spi_desc = {
 	.setup = acpi_apd_setup,
 	.fixed_clk_rate = 250000000,
 };
+
+static const struct apd_device_desc hjmc_i2c_desc = {
+	.setup = acpi_apd_setup,
+	.fixed_clk_rate = 200000000,
+};
 #endif /* CONFIG_ARM64 */
 
 #endif
@@ -252,6 +257,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
 	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
 	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
+	{ "HJMC3001", APD_ADDR(hjmc_i2c_desc) },
 #endif
 	{ }
 };
-- 
2.27.0

[PATCH 2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

[hunter.yu]

From: "hunter.yu" <hunter.yu@hj-micro.com>

Define a new ACPI HID for HJMC01

Signed-off-by: hunter.yu <hunter.yu@hj-micro.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index df3dc1e8093e..06dcefa3b103 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -58,6 +58,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
 	{ "HYGO0010", ACCESS_INTR_MASK },
+	{ "HJMC3001", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
-- 
2.27.0

Re: [PATCH 2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

[Jarkko Nikula]

On 9/19/24 9:29 AM, hunter.yu@hj-micro.com wrote:
> From: "hunter.yu" <hunter.yu@hj-micro.com>
> 
> Define a new ACPI HID for HJMC01
> 
> Signed-off-by: hunter.yu <hunter.yu@hj-micro.com>
> ---
>   drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index df3dc1e8093e..06dcefa3b103 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -58,6 +58,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>   	{ "HISI02A2", 0 },
>   	{ "HISI02A3", 0 },
>   	{ "HYGO0010", ACCESS_INTR_MASK },
> +	{ "HJMC3001", 0 },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Re: [PATCH 1/2] ACPI: APD: Add clock frequency for HJMC01 I2C controller

[Andy Shevchenko]

On Thu, Sep 19, 2024 at 02:29:42PM +0800, hunter.yu@hj-micro.com wrote:
> From: "hunter.yu" <hunter.yu@hj-micro.com>
> 
> I2C clock frequency for HJMC01 is 200M, define a new ACPI
> HID for it.

...

>  	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
>  	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
>  	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
> +	{ "HJMC3001", APD_ADDR(hjmc_i2c_desc) },

Please, keep it ordered.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

[Andy Shevchenko]

On Thu, Sep 19, 2024 at 02:29:43PM +0800, hunter.yu@hj-micro.com wrote:
> From: "hunter.yu" <hunter.yu@hj-micro.com>
> 
> Define a new ACPI HID for HJMC01

Missing period at the end.

...

>  	{ "HISI02A2", 0 },
>  	{ "HISI02A3", 0 },
>  	{ "HYGO0010", ACCESS_INTR_MASK },
> +	{ "HJMC3001", 0 },

Please, keep them ordered.

-- 
With Best Regards,
Andy Shevchenko