From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Thomas Weißschuh" <thomas@weissschuh.net>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 1/1] ACPI: battery: Check for error code from devm_mutex_init() call
Date: Thu, 31 Oct 2024 09:08:40 +0200 [thread overview]
Message-ID: <ZyMs-Ao8lUfMqYdB@smile.fi.intel.com> (raw)
In-Reply-To: <550e1dd5-91fb-44ae-bbd5-a10ce1b73ad4@weissschuh.net>
On Wed, Oct 30, 2024 at 12:29:31PM -0600, Thomas Weißschuh wrote:
> Oct 30, 2024 11:31:21 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> > On Wed, Oct 30, 2024 at 10:42:18AM -0600, Thomas Weißschuh wrote:
> >> Oct 30, 2024 10:28:03 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
...
> >> wouldn't it make sense to mark devm_mutex_init() as __must_check?
> >
> > It's macro, any idea how to do that for the macros?
>
> It should work on __devm_mutex_init().
> I don't think the expression macro in between should interfere.
> Unfortunately I can't test it myself right now.
Okay, when you have a patch, feel free to Cc me for review.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-31 7:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 16:27 [PATCH v1 1/1] ACPI: battery: Check for error code from devm_mutex_init() call Andy Shevchenko
2024-10-30 16:42 ` Thomas Weißschuh
2024-10-30 17:31 ` Andy Shevchenko
2024-10-30 18:29 ` Thomas Weißschuh
2024-10-31 7:08 ` Andy Shevchenko [this message]
2024-11-04 16:56 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyMs-Ao8lUfMqYdB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=thomas@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox