Re: [PATCH v10 00/22] Add support for binding ACPI platform profile to multiple drivers

Ilpo Järvinen
2024-12-12T14:11:19Z

[-- Attachment #1: Type: text/plain, Size: 5517 bytes --]

On Tue, 10 Dec 2024, Rafael J. Wysocki wrote:

> Hi Ilpo,
>
> On Tue, Dec 10, 2024 at 6:30 PM Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > Hi Rafael,
> >
> > This series seems ready and Mario has requested it to be merged through
> > platform drivers tree despite majority of changes touching
> > drivers/acpi/platform_profile.c because its API relates to many pdx86
> > drivers.
> >
> > Is that fine with you?
>
> Yes, it is, thanks!

Thanks all.

The series has been applied into pdx86/platform-drivers-x86-platform-profile
and then merged into the for-next branch.

--
i.

> > On Thu, 5 Dec 2024, Mario Limonciello wrote:
> >
> > > Currently there are a number of ASUS products on the market that happen to
> > > have ACPI objects for amd-pmf to bind to as well as an ACPI platform
> > > profile provided by asus-wmi.
> > >
> > > The ACPI platform profile support created by amd-pmf on these ASUS
> > > products is "Function 9" which is specifically for "BIOS or EC
> > > notification" of power slider position. This feature is actively used
> > > by some designs such as Framework 13 and Framework 16.
> > >
> > > On these ASUS designs we keep on quirking more and more of them to turn
> > > off this notification so that asus-wmi can bind.
> > >
> > > This however isn't how Windows works. "Multiple" things are notified for
> > > the power slider position. This series adjusts Linux to behave similarly.
> > >
> > > Multiple drivers can now register an ACPI platform profile and will react
> > > to set requests.
> > >
> > > To avoid chaos, only positions that are common to both drivers are
> > > accepted when the legacy /sys/firmware/acpi/platform_profile interface
> > > is used.
> > >
> > > This series also adds a new concept of a "custom" profile. This allows
> > > userspace to discover that there are multiple driver handlers that are
> > > configured differently.
> > >
> > > This series also allows dropping all of the PMF quirks from amd-pmf.
> > >
> > > NOTE: Although this series changes code in acpi platform profile, I think
> > > it is better to go through the platform-x86 tree as more drivers can
> > > be introduced during the kernel cycle and should make the changes to
> > > support class interface when merging.
> > >
> > > v10:
> > > * Whitespace changes
> > > * Documentation update for custom in a single driver
> > >
> > > Mario Limonciello (22):
> > > ACPI: platform-profile: Add a name member to handlers
> > > platform/x86/dell: dell-pc: Create platform device
> > > ACPI: platform_profile: Add device pointer into platform profile
> > > handler
> > > ACPI: platform_profile: Add platform handler argument to
> > > platform_profile_remove()
> > > ACPI: platform_profile: Pass the profile handler into
> > > platform_profile_notify()
> > > ACPI: platform_profile: Move sanity check out of the mutex
> > > ACPI: platform_profile: Move matching string for new profile out of
> > > mutex
> > > ACPI: platform_profile: Use guard(mutex) for register/unregister
> > > ACPI: platform_profile: Use `scoped_cond_guard`
> > > ACPI: platform_profile: Create class for ACPI platform profile
> > > ACPI: platform_profile: Add name attribute to class interface
> > > ACPI: platform_profile: Add choices attribute for class interface
> > > ACPI: platform_profile: Add profile attribute for class interface
> > > ACPI: platform_profile: Notify change events on register and
> > > unregister
> > > ACPI: platform_profile: Only show profiles common for all handlers
> > > ACPI: platform_profile: Add concept of a "custom" profile
> > > ACPI: platform_profile: Make sure all profile handlers agree on
> > > profile
> > > ACPI: platform_profile: Check all profile handler to calculate next
> > > ACPI: platform_profile: Notify class device from
> > > platform_profile_notify()
> > > ACPI: platform_profile: Allow multiple handlers
> > > platform/x86/amd: pmf: Drop all quirks
> > > Documentation: Add documentation about class interface for platform
> > > profiles
> > >
> > > .../ABI/testing/sysfs-platform_profile | 5 +
> > > .../userspace-api/sysfs-platform_profile.rst | 38 ++
> > > drivers/acpi/platform_profile.c | 534 ++++++++++++++----
> > > .../surface/surface_platform_profile.c | 8 +-
> > > drivers/platform/x86/acer-wmi.c | 12 +-
> > > drivers/platform/x86/amd/pmf/Makefile | 2 +-
> > > drivers/platform/x86/amd/pmf/core.c | 1 -
> > > drivers/platform/x86/amd/pmf/pmf-quirks.c | 66 ---
> > > drivers/platform/x86/amd/pmf/pmf.h | 3 -
> > > drivers/platform/x86/amd/pmf/sps.c | 4 +-
> > > drivers/platform/x86/asus-wmi.c | 8 +-
> > > drivers/platform/x86/dell/alienware-wmi.c | 8 +-
> > > drivers/platform/x86/dell/dell-pc.c | 38 +-
> > > drivers/platform/x86/hp/hp-wmi.c | 8 +-
> > > drivers/platform/x86/ideapad-laptop.c | 6 +-
> > > .../platform/x86/inspur_platform_profile.c | 7 +-
> > > drivers/platform/x86/thinkpad_acpi.c | 16 +-
> > > include/linux/platform_profile.h | 9 +-
> > > 18 files changed, 559 insertions(+), 214 deletions(-)
> > > delete mode 100644 drivers/platform/x86/amd/pmf/pmf-quirks.c
> >
> > --
> > i.
> >
>