From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 650AB2236FA; Mon, 29 Sep 2025 17:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759167889; cv=none; b=cA/NRvabJEZqgKJEcuPz6QYPdrZ9hu7Refem4NVNNKPSMLUqxpxUi4SEi3duHLQet+MkbXGwmx9HurcFMBQusQ2QKyrPvuonHaIJi8ipqkmAiOFD3ho4Umzhw6WOJ/HYxWFbVvZGAfqS4U3tt9Ki3LvxrJMuWJvIxIDcL7BmjCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759167889; c=relaxed/simple; bh=iXN67G501gPL6RvW3Uub3rUfluyVcfF06QXzRZZee8I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=no0m4Ppb1GMNeyzzsEbxANGumFkmjjjsy8xz7wtxMT85bm75MRTLlzlIDyrn7lTuSsW6k3YntCT/E+FHuv+fET6jE7KZDAvtubWx5kmlus5OoEs5FOtAqhAy5IqQ/0p23j6DSqbWDaixrgrZSF41q7S3e1/NXYwvBiC28WHD3UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF1491758; Mon, 29 Sep 2025 10:44:39 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E5123F59E; Mon, 29 Sep 2025 10:44:42 -0700 (PDT) Message-ID: Date: Mon, 29 Sep 2025 18:44:39 +0100 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/29] arm_mpam: Probe hardware to find the supported partid/pmg values To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-12-james.morse@arm.com> <0382ea8a-8f15-4983-8659-0471f9090012@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <0382ea8a-8f15-4983-8659-0471f9090012@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Ben, On 12/09/2025 12:11, Ben Horgan wrote: > On 9/10/25 21:42, James Morse wrote: >> CPUs can generate traffic with a range of PARTID and PMG values, >> but each MSC may also have its own maximum size for these fields. >> Before MPAM can be used, the driver needs to probe each RIS on >> each MSC, to find the system-wide smallest value that can be used. >> The limits from requestors (e.g. CPUs) also need taking into account. >> >> While doing this, RIS entries that firmware didn't describe are created >> under MPAM_CLASS_UNKNOWN. >> >> While we're here, implement the mpam_register_requestor() call >> for the arch code to register the CPU limits. Future callers of this >> will tell us about the SMMU and ITS. > Looks good to me. I think Jonathan's comment on getting rid of the local > variable, 'found', is worthwhile. > > Reviewed-by: Ben Horgan Thanks! James