From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]
Date: Mon, 7 Dec 2020 17:57:21 +0100 [thread overview]
Message-ID: <a78eed2a-4c33-7e1a-88df-d92e33c74e20@redhat.com> (raw)
In-Reply-To: <12017158.VsPUki9SGr@kreacher>
Hi,
On 12/7/20 5:55 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> According to Hans, all device objects where the _HID returns
> "INT3396" also have a _CID returning "PNP0D80", so the former
> need not be present in acpi_ignore_dep_ids[] any more.
>
> Link: https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93cf05fb4877@redhat.com/
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks, patch looks good to me. FWIW:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
>
> On top of https://patchwork.kernel.org/project/linux-acpi/patch/3849919.JfvvSOo2yN@kreacher/
>
> ---
> drivers/acpi/scan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -751,7 +751,6 @@ static bool acpi_info_matches_ids(struct
>
> /* List of HIDs for which we ignore matching ACPI devices, when checking _DEP lists. */
> static const char * const acpi_ignore_dep_ids[] = {
> - "INT3396", /* Windows System Power Management Controller */
> "PNP0D80", /* Windows-compatible System Power Management Controller */
> NULL
> };
>
>
>
prev parent reply other threads:[~2020-12-07 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 16:55 [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[] Rafael J. Wysocki
2020-12-07 16:57 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78eed2a-4c33-7e1a-88df-d92e33c74e20@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).