Re: [PATCH v2 6/6] drivers/pci/hyperv/arm64: vPCI MSI IRQ domain from DT

Roman Kisel
2024-05-15T18:34:19Z

On 5/15/2024 11:12 AM, Bjorn Helgaas wrote:
> On Wed, May 15, 2024 at 09:34:09AM -0700, Roman Kisel wrote:
>>
>>
>> On 5/15/2024 2:48 AM, Saurabh Singh Sengar wrote:
>>> On Tue, May 14, 2024 at 03:43:53PM -0700, Roman Kisel wrote:
>>>> The hyperv-pci driver uses ACPI for MSI IRQ domain configuration
>>>> on arm64 thereby it won't be able to do that in the VTL mode where
>>>> only DeviceTree can be used.
>>>>
>>>> Update the hyperv-pci driver to discover interrupt configuration
>>>> via DeviceTree.
>>>
>>> Subject prefix should be "PCI: hv:"
>>>
>> Thanks!
>
> "git log --oneline <file>" is a good guide in general and could be
> used for other patches in this series as well.
>
Many thanks for suggesting that :)

>>>> + hv_msi_gic_irq_domain = acpi_irq_create_hierarchy(0, HV_PCI_MSI_SPI_NR,
>>>> + fn, &hv_pci_domain_ops,
>>>> + chip_data);
>>>
>>> Upto 100 characters per line are supported now, we can have less
>>> line breaks.
>>>
>> Fewer line breaks would make this look nicer, let me know if you had any
>> particular style in mind.
>
> Let's not use the checkpatch "$max_line_length = 100" as a guide.
>
> The pci-hyperv.c file as a whole is obviously formatted to fit in 80
> columns with few exceptions.
>
> IMO it would not be an improvement to scatter random 100-column lines
> throughout. That would just mean the file would look bad in an
> 80-column terminal and there would be a lot of wasted space in a
> 100-column terminal.
>
Appreciate showing me the data-driven way of reasoning about that very much!

> Bjorn

--
Thank you,
Roman