Re: [PATCH v4 5/7] iommu: Add iommu_get_domain_for_dev_locked() helper

Nicolin Chen
2025-09-19T23:15:17Z

On Fri, Sep 12, 2025 at 09:36:38AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Monday, September 1, 2025 7:32 AM
> >
> >
> > +/* Caller must be a general/external function that isn't an IOMMU callback
> > */
> > struct iommu_domain *iommu_get_domain_for_dev(struct device *dev)
> > {
>
> 'general function' is not easy to get its meaning. just keep 'external'?

This is still one internal function use this:
drivers/iommu/dma-iommu.c:1785: iommu_deferred_attach(dev, iommu_get_domain_for_dev(dev)))

So, it's not completely "external" :-/

Thanks
Nicolin