Re: [PATCH 12/14] leds: Use fwnode_get_next_child_node() instead

Sakari Ailus
2025-09-23T08:29:35Z

Hi Andy,

Thanks for the review.

On Tue, Sep 23, 2025 at 08:46:38AM +0300, Andy Shevchenko wrote:
> On Tue, Sep 16, 2025 at 07:01:27PM +0300, Sakari Ailus wrote:
> > fwnode_get_next_child_node() is now the same as
> > fwnode_get_next_available_child_node() on all backends (OF, ACPI and
> > swnode). In order to remove the available variants, switch the uses to
> > non-available variants.
>
> ...
>
> > --- a/drivers/leds/flash/leds-rt4505.c
> > +++ b/drivers/leds/flash/leds-rt4505.c
>
> > - child = fwnode_get_next_available_child_node(client->dev.fwnode, NULL);
> > + child = fwnode_get_next_child_node(client->dev.fwnode, NULL);
>
> Can we move to device_get_next_child_node() instead?
>
> ...
>
> > --- a/drivers/leds/flash/leds-rt8515.c
> > +++ b/drivers/leds/flash/leds-rt8515.c
>
> > - child = fwnode_get_next_available_child_node(dev->fwnode, NULL);
> > + child = fwnode_get_next_child_node(dev->fwnode, NULL);
>
> Ditto.
>
> ...
>
> > --- a/drivers/leds/flash/leds-sgm3140.c
> > +++ b/drivers/leds/flash/leds-sgm3140.c
>
> > - child_node = fwnode_get_next_available_child_node(pdev->dev.fwnode,
> > - NULL);
> > + child_node = fwnode_get_next_child_node(pdev->dev.fwnode, NULL);
>
> Ditto.
>
> ...
>
> > --- a/drivers/leds/flash/leds-tps6131x.c
> > +++ b/drivers/leds/flash/leds-tps6131x.c
>
> > - tps6131x->led_node = fwnode_get_next_available_child_node(dev->fwnode, NULL);
> > + tps6131x->led_node = fwnode_get_next_child_node(dev->fwnode, NULL);
>
> Ditto.

I'll fix these for v2.

--
Regards,

Sakari Ailus