Re: [PATCH 04/14] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id()

Sakari Ailus
2025-09-17T12:19:17Z

Hi Andy,

On Wed, Sep 17, 2025 at 11:39:29AM +0300, Andy Shevchenko wrote:
> On Tue, Sep 16, 2025 at 07:01:19PM +0300, Sakari Ailus wrote:
> > No caller uses FWNODE_GRAPH_DEVICE_DISABLED flag when calling
> > fwnode_graph_get_endpoint_by_id(). Drop support for the flag entirely and
> > remove it from the documentation.
>
> ...
>
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
>
> > * If FWNODE_GRAPH_ENDPOINT_NEXT is passed in @flags and the specified endpoint
> > * has not been found, look for the closest endpoint ID greater than the
> > * specified one and return the endpoint that corresponds to it, if present.
> > - *
> > - * Does not return endpoints that belong to disabled devices or endpoints that
> > - * are unconnected, unless FWNODE_GRAPH_DEVICE_DISABLED is passed in @flags.
> > */
>
> Since you are touching a few kernel-doc descriptions, can you make sure that
> they have Return sections where appropriate?

This one does but it's not at the end of the description. I'll move it
there in a separate patch.

--
Sakari Ailus