From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-spi@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Danilo Krummrich <dakr@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Javier Carrasco <javier.carrasco@wolfvision.net>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Matthias Fend <matthias.fend@emfend.at>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Paul Elder <paul.elder@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mark Brown <broonie@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 02/16] ACPI: property: Use ACPI functions in acpi_graph_get_next_endpoint() only
Date: Fri, 26 Sep 2025 09:18:18 +0300 [thread overview]
Message-ID: <aNYwKkYW__0hRIQV@kekkonen.localdomain> (raw)
In-Reply-To: <iqfarpvf72l7qbhfinopjb27qvfm7wg77d4yhuy5qyubcwtcd2@exmcuvgqr353>
Hi Dmitry,
On Wed, Sep 24, 2025 at 11:32:56AM -0700, Dmitry Torokhov wrote:
> Hi Sakari,
>
> On Wed, Sep 24, 2025 at 10:45:48AM +0300, Sakari Ailus wrote:
> > Calling fwnode_get_next_child_node() in ACPI implementation of the fwnode
> > property API is somewhat problematic as the latter is used in the
>
> How exactly is this problematic?
In general, the fwnode property API is implemented by the (currently three)
backends so the backend calling fwnode property API to call itself without
knowing what exactly gets called may end up in an infinite recursion.
Keeping ACPI implementation separate from the fwnode property frontend
avoids even needing to think about this.
>
> > impelementation of the former. Instead of using
> > fwnode_get_next_child_node() in acpi_graph_get_next_endpoint(), call
> > acpi_get_next_subnode() directly instead.
>
> I think we are moving into the world of mixed fwnode types with software
> nodes/secondary fwnodes, so I do not think this is a step in right
> direction.
This is not how it works. If you have an ACPI node, it's and ACPI node, not
a software node or an OF node. A software node would be attached as
fwnode->secondary, it's not the same ACPI (device or data) node.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2025-09-26 6:18 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 7:45 [PATCH v2 00/16] Align availability checks on fwnode child node enumeration Sakari Ailus
2025-09-24 7:45 ` [PATCH v2 01/16] ACPI: property: Make acpi_get_next_subnode() static Sakari Ailus
2025-09-24 9:27 ` Laurent Pinchart
2025-09-24 9:49 ` Laurent Pinchart
2025-09-29 9:10 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 02/16] ACPI: property: Use ACPI functions in acpi_graph_get_next_endpoint() only Sakari Ailus
2025-09-24 9:29 ` Laurent Pinchart
2025-09-24 18:32 ` Dmitry Torokhov
2025-09-26 6:18 ` Sakari Ailus [this message]
2025-09-29 9:11 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 03/16] ACPI: property: Rework acpi_graph_get_next_endpoint() Sakari Ailus
2025-09-24 9:39 ` Laurent Pinchart
2025-09-26 11:49 ` Sakari Ailus
2025-09-24 7:45 ` [PATCH v2 04/16] ACPI: property: Return present device nodes only on fwnode interface Sakari Ailus
2025-09-24 9:57 ` Laurent Pinchart
2025-09-29 9:35 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 05/16] property: Move Return: section of fwnode_graph_get_endpoint_by_id() down Sakari Ailus
2025-09-24 9:58 ` Laurent Pinchart
2025-09-29 9:37 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 06/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_by_id() Sakari Ailus
2025-09-24 9:59 ` Laurent Pinchart
2025-09-24 7:45 ` [PATCH v2 07/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_count() Sakari Ailus
2025-09-24 10:00 ` Laurent Pinchart
2025-09-29 9:40 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 08/16] property: Document that fwnode API returns available nodes Sakari Ailus
2025-09-24 10:06 ` Laurent Pinchart
2025-09-29 9:44 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 09/16] driver core: Use fwnode_for_each_child_node() instead Sakari Ailus
2025-09-24 10:01 ` Laurent Pinchart
2025-09-29 9:47 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 10/16] net: lan966x: " Sakari Ailus
2025-09-24 10:02 ` Laurent Pinchart
2025-09-29 9:48 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 11/16] Input: touch-overlay - " Sakari Ailus
2025-09-24 10:02 ` Laurent Pinchart
2025-09-24 18:36 ` Dmitry Torokhov
2025-09-29 9:49 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 12/16] media: thp7312: " Sakari Ailus
2025-09-24 10:02 ` Laurent Pinchart
2025-09-25 10:40 ` Paul Elder
2025-09-29 9:50 ` Jonathan Cameron
2025-09-24 7:45 ` [PATCH v2 13/16] leds: " Sakari Ailus
2025-09-24 10:02 ` Laurent Pinchart
2025-09-29 9:51 ` Jonathan Cameron
2025-09-24 7:46 ` [PATCH v2 14/16] leds: Use fwnode_get_next_child_node() instead Sakari Ailus
2025-09-24 10:03 ` Laurent Pinchart
2025-09-29 9:51 ` Jonathan Cameron
2025-09-24 7:46 ` [PATCH v2 15/16] property: Drop functions operating on "available" child nodes Sakari Ailus
2025-09-24 10:04 ` Laurent Pinchart
2025-09-29 9:53 ` Jonathan Cameron
2025-09-24 7:46 ` [PATCH v2 16/16] spi: cadence: Remove explicit device node availability check Sakari Ailus
2025-09-24 8:38 ` Mark Brown
2025-09-24 10:04 ` Laurent Pinchart
2025-09-29 9:54 ` Jonathan Cameron
2025-09-24 10:52 ` [PATCH v2 00/16] Align availability checks on fwnode child node enumeration Rafael J. Wysocki
2025-09-26 11:48 ` Sakari Ailus
2025-09-26 12:52 ` Rafael J. Wysocki
2025-10-09 12:38 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNYwKkYW__0hRIQV@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horatiu.vultur@microchip.com \
--cc=javier.carrasco@wolfvision.net \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.elder@ideasonboard.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox