linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Will Deacon <will@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sven Peter <sven@kernel.org>, Janne Grunau <j@jannau.net>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	James Clark <james.clark@linaro.org>,
	Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v3 00/26] genirq: Add support for percpu_devid IRQ affinity
Date: Fri, 26 Sep 2025 11:38:30 +0100	[thread overview]
Message-ID: <aNZtJoFrOv8dHlkV@raptor> (raw)
In-Reply-To: <20250922082833.2038905-1-maz@kernel.org>

Hi,

Tested this on a rockpro64 - 4xA53 + 2xA72.

On kernel v6.17-rc5, using perf to profile iperf3 for 10 seconds, the top
overhead symbol was _raw_spinlock_irq_restore() and the PMU wasn't using NMIs
(checked by printing has_nmi after armpmu_request_irq()).

With this series, same test, *irq_restore() overhead dropped to about 1% on the
little core, below 1% on the big core, and the PMU was using NMIs.

Thanks,
Alex

On Mon, Sep 22, 2025 at 09:28:07AM +0100, Marc Zyngier wrote:
> This is the third version of this series, originally posted at [1],
> which aims at allowing percpu_devid interrupt requests on the basis of
> an affinity mask. See the original submission for the details of why
> this is a desirable outcome.
> 
> From v2, we have some tidying up, thanks to Jonathan's review -- see
> changelog for details.
> 
> FWIW, I've pushed a branch at [3].
> 
> * From v2 [2]:
> 
>   - Turned of_node_to_fwnode() usage to of_fwnode_handle() (Jonathan)
> 
>   - Added a patch to finally kill of_node_to_fwnode()
> 
>   - Tidied-up documentation, comments and formatting (Jonathan)
> 
>   - Collected ABs and Rbs, with thanks (Jonathan, Suzuki, Sven)
> 
> * From v1 [1]:
> 
>   - Fixed NMI handling by getting rid of the NMI-specific flow
>     handler, which was pretty useless anyway (Will)
> 
>   - As a result, killed a metric buttload worth of GICv3 code
> 
>   - Moved irq_fwspec out of irq_fwspec_info, and passed it as a
>     parameter to irq_get_fwspec_info(), renamed from irq_get_info(),
>     and applied some generous sanitisation of the structure (Thomas)
> 
>   - Dropped the rather useless fwspec validity flag (Thomas)
> 
>   - Rejigged the PMU per-CPU handling to better deal with the DT/ACPI
>     differences, and drop some now useless patches (Will)
> 
>   - Plenty of cosmetic rework (Raphael, Thomas)
> 
> [1] https://lore.kernel.org/r/20250908163127.2462948-1-maz@kernel.org
> [2] https://lore.kernel.org/r/20250915085702.519996-1-maz@kernel.org
> [3] git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/ppi-affinity

      parent reply	other threads:[~2025-09-26 10:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22  8:28 [PATCH v3 00/26] genirq: Add support for percpu_devid IRQ affinity Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 01/26] irqdomain: Add firmware info reporting interface Marc Zyngier
2025-10-09 16:42   ` Jonathan Cameron
2025-09-22  8:28 ` [PATCH v3 02/26] ACPI: irq: Add IRQ affinity " Marc Zyngier
2025-09-22 17:10   ` Rafael J. Wysocki
2025-10-09 16:47   ` Jonathan Cameron
2025-09-22  8:28 ` [PATCH v3 03/26] of/irq: " Marc Zyngier
2025-10-09 16:49   ` Jonathan Cameron
2025-10-20 10:47     ` Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 04/26] platform: Add firmware-agnostic irq and affinity retrieval interface Marc Zyngier
2025-10-09 17:03   ` Jonathan Cameron
2025-10-20 10:44     ` Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 05/26] irqchip/gic-v3: Add FW info retrieval support Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 06/26] irqchip/apple-aic: " Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 07/26] coresight: trbe: Convert to new IRQ affinity retrieval API Marc Zyngier
2025-09-23 11:17   ` Suzuki K Poulose
2025-09-22  8:28 ` [PATCH v3 08/26] perf: arm_pmu: " Marc Zyngier
2025-10-10  3:39   ` Jinjie Ruan
2025-09-22  8:28 ` [PATCH v3 09/26] perf: arm_spe_pmu: " Marc Zyngier
2025-10-10  3:41   ` Jinjie Ruan
2025-09-22  8:28 ` [PATCH v3 10/26] irqchip/gic-v3: Switch high priority PPIs over to handle_percpu_devid_irq() Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 11/26] genirq: Kill handle_percpu_devid_fasteoi_nmi() Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id} Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 13/26] genirq: Factor-in percpu irqaction creation Marc Zyngier
2025-10-10  3:59   ` Jinjie Ruan
2025-10-10  9:28     ` Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 14/26] genirq: Add affinity to percpu_devid interrupt requests Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 15/26] genirq: Update request_percpu_nmi() to take an affinity Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 16/26] genirq: Allow per-cpu interrupt sharing for non-overlapping affinities Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 17/26] genirq: Add request_percpu_irq_affinity() helper Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 18/26] perf: arm_pmu: Request specific affinities for percpu NMI/IRQ Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 19/26] perf: arm_spe_pmu: Request specific affinities for percpu IRQ Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 20/26] coresight: trbe: " Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 21/26] irqchip/gic-v3: Drop support for custom PPI partitions Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 22/26] irqchip/apple-aic: Drop support for custom PMU irq partitions Marc Zyngier
2025-09-22 18:43   ` Sven Peter
2025-09-22 20:24     ` Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 23/26] irqchip: Kill irq-partition-percpu Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 24/26] genirq: Kill irq_{g,s}et_percpu_devid_partition() Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 25/26] irqdomain: Kill of_node_to_fwnode() helper Marc Zyngier
2025-09-22  8:28 ` [PATCH v3 26/26] perf: arm_pmu: Kill last use of per-CPU cpu_armpmu pointer Marc Zyngier
2025-09-23 10:00 ` [PATCH v3 00/26] genirq: Add support for percpu_devid IRQ affinity Will Deacon
2025-09-23 10:09   ` Marc Zyngier
2025-09-26 10:38 ` Alexandru Elisei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNZtJoFrOv8dHlkV@raptor \
    --to=alexandru.elisei@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=j@jannau.net \
    --cc=james.clark@linaro.org \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=saravanak@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=sven@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).