public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: rafael@kernel.org, regressions@lists.linux.dev, lenb@kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	apatel@ventanamicro.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Daniele Cleri <DanieleCleri@aaeon.eu>
Subject: Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI
Date: Fri, 17 Oct 2025 03:52:53 +0530	[thread overview]
Message-ID: <aPFwPR2A0CN6k1Vl@sunil-laptop> (raw)
In-Reply-To: <c321423b-3cdb-41a5-9939-dc5c846cfcd4@bootlin.com>

On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
> Hello,
> 
> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
> noticed a regression. The driver does not probe anymore and I get the
> following error:
> 
> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
> initialize FPGA common GPIOs
> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
> failed with error -2
> 
> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
> 
> I did a bisect and I found the commit which introduced the regression:
> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
> to support nargs_prop")
> 
Hi Thomas,

Could you please try with below change and see if it resolves the issue?

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 1b997a5497e7..43d5e457814e 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
                                       size_t num_args,
                                       struct fwnode_reference_args *args)
 {
-       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
+       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
 }

Thanks,
Sunil

  reply	other threads:[~2025-10-16 22:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 12:47 [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI Thomas Richard
2025-10-16 22:22 ` Sunil V L [this message]
2025-10-17  8:50   ` Thomas Richard
2025-10-17 10:02     ` Sunil V L
2025-10-18 19:14       ` Andy Shevchenko
2025-10-18 19:34         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPFwPR2A0CN6k1Vl@sunil-laptop \
    --to=sunilvl@ventanamicro.com \
    --cc=DanieleCleri@aaeon.eu \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apatel@ventanamicro.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas.richard@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox