[REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Thomas Richard]

Hello,

While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
noticed a regression. The driver does not probe anymore and I get the
following error:

[    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
initialize FPGA common GPIOs
[    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
failed with error -2

The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].

I did a bisect and I found the commit which introduced the regression:
e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
to support nargs_prop")

Best Regards,

Thomas

[1]
https://elixir.bootlin.com/linux/v6.17/source/drivers/mfd/upboard-fpga.c#L192
[2] https://gist.github.com/thom24/2da44ef86eacfa5d2d492ce43fa41aa4

Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Sunil V L]

On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
> Hello,
> 
> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
> noticed a regression. The driver does not probe anymore and I get the
> following error:
> 
> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
> initialize FPGA common GPIOs
> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
> failed with error -2
> 
> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
> 
> I did a bisect and I found the commit which introduced the regression:
> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
> to support nargs_prop")
> 
Hi Thomas,

Could you please try with below change and see if it resolves the issue?

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 1b997a5497e7..43d5e457814e 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
                                       size_t num_args,
                                       struct fwnode_reference_args *args)
 {
-       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
+       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
 }

Thanks,
Sunil

Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Thomas Richard]

On 10/17/25 12:22 AM, Sunil V L wrote:
> On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
>> Hello,
>>
>> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
>> noticed a regression. The driver does not probe anymore and I get the
>> following error:
>>
>> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
>> initialize FPGA common GPIOs
>> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
>> failed with error -2
>>
>> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
>>
>> I did a bisect and I found the commit which introduced the regression:
>> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
>> to support nargs_prop")
>>
> Hi Thomas,
> 
> Could you please try with below change and see if it resolves the issue?
> 
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 1b997a5497e7..43d5e457814e 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
>                                        size_t num_args,
>                                        struct fwnode_reference_args *args)
>  {
> -       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
> +       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
>  }
> 

Hi Sunil,

Yes your change fixes the issue !!

Thanks,

Thomas

Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Sunil V L]

On Fri, Oct 17, 2025 at 10:50:05AM +0200, Thomas Richard wrote:
> On 10/17/25 12:22 AM, Sunil V L wrote:
> > On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
> >> Hello,
> >>
> >> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
> >> noticed a regression. The driver does not probe anymore and I get the
> >> following error:
> >>
> >> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
> >> initialize FPGA common GPIOs
> >> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
> >> failed with error -2
> >>
> >> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
> >>
> >> I did a bisect and I found the commit which introduced the regression:
> >> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
> >> to support nargs_prop")
> >>
> > Hi Thomas,
> > 
> > Could you please try with below change and see if it resolves the issue?
> > 
> > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> > index 1b997a5497e7..43d5e457814e 100644
> > --- a/drivers/acpi/property.c
> > +++ b/drivers/acpi/property.c
> > @@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
> >                                        size_t num_args,
> >                                        struct fwnode_reference_args *args)
> >  {
> > -       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
> > +       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
> >  }
> > 
> 
> Hi Sunil,
> 
> Yes your change fixes the issue !!
> 
Hi Thomas,

Thanks for confirming the fix!

I'll send out the patch shortly and include your Tested-by tag.

Apologies for the earlier issue, and thank you for your help.

Best regards,
Sunil

Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Andy Shevchenko]

On Fri, Oct 17, 2025 at 03:32:26PM +0530, Sunil V L wrote:
> On Fri, Oct 17, 2025 at 10:50:05AM +0200, Thomas Richard wrote:
> > On 10/17/25 12:22 AM, Sunil V L wrote:
> > > On Thu, Oct 16, 2025 at 02:47:40PM +0200, Thomas Richard wrote:
> > >>
> > >> While testing the AAEON UpBoard MFD driver with the v6.18-rc1 release, I
> > >> noticed a regression. The driver does not probe anymore and I get the
> > >> following error:
> > >>
> > >> [    1.977831] upboard-fpga AANT0F01:00: error -ENOENT: Failed to
> > >> initialize FPGA common GPIOs
> > >> [    1.977854] upboard-fpga AANT0F01:00: probe with driver upboard-fpga
> > >> failed with error -2
> > >>
> > >> The driver fails to get some GPIOs using a name [1] in the ACPI tables [2].
> > >>
> > >> I did a bisect and I found the commit which introduced the regression:
> > >> e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args()
> > >> to support nargs_prop")
> > > 
> > > Could you please try with below change and see if it resolves the issue?
> > > 
> > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> > > index 1b997a5497e7..43d5e457814e 100644
> > > --- a/drivers/acpi/property.c
> > > +++ b/drivers/acpi/property.c
> > > @@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
> > >                                        size_t num_args,
> > >                                        struct fwnode_reference_args *args)
> > >  {
> > > -       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
> > > +       return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
> > >  }
> > 
> > Yes your change fixes the issue !!
> 
> Thanks for confirming the fix!
> 
> I'll send out the patch shortly and include your Tested-by tag.
> 
> Apologies for the earlier issue, and thank you for your help.

I haven't received anything. Have you sent anything? Am I Cc'ed?

-- 
With Best Regards,
Andy Shevchenko

Re: [REGRESSION] in 6.18-rc1, failed to query a GPIO using a name in ACPI

[Andy Shevchenko]

On Sat, Oct 18, 2025 at 10:14:19PM +0300, Andy Shevchenko wrote:
> On Fri, Oct 17, 2025 at 03:32:26PM +0530, Sunil V L wrote:
> > On Fri, Oct 17, 2025 at 10:50:05AM +0200, Thomas Richard wrote:

Seems I have had an issue with my email, and everything is now fine.

> > I'll send out the patch shortly and include your Tested-by tag.
> > 
> > Apologies for the earlier issue, and thank you for your help.
> 
> I haven't received anything. Have you sent anything? Am I Cc'ed?

-- 
With Best Regards,
Andy Shevchenko