Re: [PATCH v3 01/10] software node: read the reference args via the fwnode API

Andy Shevchenko
2025-10-30T09:33:36Z

On Wed, Oct 29, 2025 at 01:28:35PM +0100, Bartosz Golaszewski wrote:
>
> Once we allow software nodes to reference all kinds of firmware nodes,
> the refnode here will no longer necessarily be a software node so read
> its proprties going through its fwnode implementation.

As pointed out in previous reviews this would have benefit of a short comment.
explaining the indirect call to read an array.

...

> if (nargs_prop) {
> - error = property_entry_read_int_array(ref->node->properties,
> - nargs_prop, sizeof(u32),
> - &nargs_prop_val, 1);
> + error = fwnode_property_read_u32(refnode, nargs_prop,
> + &nargs_prop_val);

It can be one line now. We are not fanatics of 80 limitation. :-)

> if (error)
> return error;

--
With Best Regards,
Andy Shevchenko