linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>
Cc: Askar Safin <safinaskar@gmail.com>,
	Dell.Client.Kernel@dell.com, bartosz.golaszewski@linaro.org,
	benjamin.tissoires@redhat.com, dmitry.torokhov@gmail.com,
	linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-i2c@vger.kernel.org, regressions@lists.linux.dev,
	rrangel@chromium.org, wse@tuxedocomputers.com
Subject: Re: [REGRESSION][BISECTED] Dell Precision 7780 wakes up on its own from suspend
Date: Fri, 5 Dec 2025 15:52:00 +0200	[thread overview]
Message-ID: <aTLjgEVfLCot0cSm@smile.fi.intel.com> (raw)
In-Reply-To: <8e3ae563-a058-40c5-a721-834d7bda141d@kernel.org>

On Thu, Dec 04, 2025 at 11:21:32PM -0600, Mario Limonciello (AMD) (kernel.org) wrote:
> On 12/4/2025 10:01 PM, Askar Safin wrote:
> > "Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>:

...

> > > But yes; failing all that it's viable to make a quirk.  You can follow
> > > any of the ones I've submitted for modeling how to do it.  Here's the
> > > most recent one I've done.
> > > 
> > > https://github.com/torvalds/linux/commit/23800ad1265f10c2bc6f42154ce4d20e59f2900e
> > 
> > Thank you! I will write something like this:
> > 
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +			DMI_MATCH(DMI_PRODUCT_FAMILY, "Precision"),
> > +		},
> > +		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
> > +			.ignore_wake = "VEN_0488:00@355",
> > +		},
> > 
> > I will test it and then properly send (hopefully today or tomorrow).
> 
> This match it too liberal.  We don't have any evidence it applies to
> anything more than your single system.  I'd pick some different strings.
> For example Product SKU is probably a good string to use because that's very
> unique.

+1. If we ever see another one, we can then think of a more generic quirk.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-12-05 13:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 23:32 [REGRESSION][BISECTED] Dell Precision 7780 wakes up on its own from suspend Askar Safin
2025-06-27  0:35 ` Mario Limonciello
2025-06-27  3:51   ` Askar Safin
2025-06-27  3:58     ` Mario Limonciello
2025-06-30  7:14       ` Askar Safin
2025-06-30 18:40         ` Mario Limonciello
2025-07-17 23:29           ` Askar Safin
2025-07-18 15:13             ` Werner Sembach
2025-07-18 15:20               ` Mario Limonciello
2025-08-25 15:34           ` Andy Shevchenko
2025-08-25 15:36             ` Andy Shevchenko
2025-09-18 18:33               ` Askar Safin
2025-11-09 19:05                 ` Andy Shevchenko
2025-11-09 19:08                   ` Andy Shevchenko
2025-12-05  2:16                     ` Askar Safin
2025-12-05  2:52                       ` Mario Limonciello (AMD) (kernel.org)
2025-12-05  4:01                         ` Askar Safin
2025-12-05  5:21                           ` Mario Limonciello (AMD) (kernel.org)
2025-12-05 13:52                             ` Andy Shevchenko [this message]
2025-12-07  4:04                               ` Askar Safin
2025-12-07 10:18                                 ` Andy Shevchenko
2025-12-07 16:45                                   ` Askar Safin
2025-12-07 22:35                                     ` Andy Shevchenko
2025-12-05 13:55                       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTLjgEVfLCot0cSm@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=rrangel@chromium.org \
    --cc=safinaskar@gmail.com \
    --cc=superm1@kernel.org \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).