From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Kartik Rajput <kkartik@nvidia.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
lenb@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ACPI: bus: Use OF match data for PRP0001 matched devices
Date: Mon, 12 Jan 2026 11:11:07 +0200 [thread overview]
Message-ID: <aWS6q3tBlppsWXXl@kekkonen.localdomain> (raw)
In-Reply-To: <aWS3HRIlZQqI1hP5@smile.fi.intel.com>
Hi Kartik, Andy,
On Mon, Jan 12, 2026 at 10:55:57AM +0200, Andy Shevchenko wrote:
> > if (!__acpi_match_device(adev, acpi_ids, of_ids, &acpi_id, &of_id))
> > return NULL;
> >
> > if (acpi_id)
> > return (const void *)acpi_id->driver_data;
> >
> > if (of_id)
> > return of_id->data;
> >
> > return NULL;
> >
> > Then, we can also remove acpi_of_device_get_match_data()?
>
> At brief look it's indeed seems to be a good optimisation as well.
Looks good to me, too!
--
Sakari Ailus
prev parent reply other threads:[~2026-01-12 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 9:53 [PATCH v3] ACPI: bus: Use OF match data for PRP0001 matched devices Kartik Rajput
2026-01-09 10:13 ` Mika Westerberg
2026-01-09 11:05 ` Andy Shevchenko
2026-01-09 11:29 ` Sakari Ailus
2026-01-09 17:02 ` Andy Shevchenko
2026-01-09 21:11 ` Rafael J. Wysocki
2026-01-11 22:01 ` Sakari Ailus
2026-01-12 8:42 ` Kartik Rajput
2026-01-12 8:55 ` Andy Shevchenko
2026-01-12 9:11 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWS6q3tBlppsWXXl@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox