From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83DE63451C6; Tue, 27 Jan 2026 11:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769512455; cv=none; b=nalTk5oJI6FuR+Tu+ow3M8eO4QIbd0ENffviHNTaegLlnmGwpe+Cf+2TytfhBL137ECsFCdeE7wyQpdVfu1EShFlMkx1bPbuBRQbPxFuJHgRWfLBm9mUyUg7LsSMrhg/kA7v74atZB6f1+PN+vHoVcDyTkrBoxEzOs4/8JkB7ps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769512455; c=relaxed/simple; bh=9Gs83gn8tecEYpFvmr++HgEc+cCrMJRna7f6l8UgdN8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z9EJsLdhMcSUF71opGNe3NBhCEIXMsNzKrsF/yMyR2v+4kuqlMdQODzvbOLb2fLVib0CW0vCrpfmhQBWHwAl3JGF0HIYx/vSiNNcIeLGtG7fxb0R2E77os2QSqJ9raHo2ybfIHqb/jCwb9/6Ld7ODqiHwfLFPnq8RBqrsNtOFsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k9r/w5g4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k9r/w5g4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 650D6C116C6; Tue, 27 Jan 2026 11:14:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769512455; bh=9Gs83gn8tecEYpFvmr++HgEc+cCrMJRna7f6l8UgdN8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k9r/w5g4dAeFIwCesvrBF6RNltI8Ld66BHBpgctZ+VFpsQoaBNY5rhOQbMlkj2Z/C Hsr4IrYy7AZG5jnAbeLBagHkIxwyXJRChpVQo3IZAXU5eODO3Up02So7B4eL0eZLAZ i8i6Tg4riMamtuLQgzXfsKYCO8+JXC84escaZzStaRLsJ5yqHJHmoi72Zta8XJaiAA fct35fcCd6b9ZJFCwGixN93RASB4K5LjYkVzCl0vG9fBQ5GJlGMiRVoBDHiU9LEHNB cZn93hPh06VvRE/BAoet20GG1FBU9qT7J7LxyYVyKLULOXB0qkwsX+AL8BFme+IBNL gTxo5OVka7R1w== Date: Tue, 27 Jan 2026 11:14:11 +0000 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: Jassi Brar , Sudeep Holla , Beleswar Padhi , Andrew Davis , Yuntao Dai , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, mailbox@lists.linux.dev, Peng Fan Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h Message-ID: References: <20260127-mailbox-v1-v1-1-cf15d7cece48@nxp.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127-mailbox-v1-v1-1-cf15d7cece48@nxp.com> On Tue, Jan 27, 2026 at 07:02:53AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > mailbox_client.h is should be used by consumer drivers, not mailbox > provider. > > Signed-off-by: Peng Fan > --- > drivers/mailbox/bcm-flexrm-mailbox.c | 1 - > drivers/mailbox/cv1800-mailbox.c | 1 - > drivers/mailbox/omap-mailbox.c | 1 - > drivers/mailbox/pcc.c | 1 - > 4 files changed, 4 deletions(-) > [...] > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index 22e70af1ae5d14e6e8c684fe032c2864f6ae4d6c..6ca84596e7637114f66d32a95d12c863e942b756 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -55,7 +55,6 @@ > #include > #include > #include > -#include > #include > #include > There is a call to mbox_bind_client() in pcc.c that is declared in linux/mailbox_client.h You didn't see any build warning or errors with this change ? Esp if build as module. -- Regards, Sudeep