* [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers
@ 2026-01-28 12:32 Peng Fan (OSS)
2026-01-28 12:48 ` Sudeep Holla
2026-02-02 0:55 ` Jassi Brar
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2026-01-28 12:32 UTC (permalink / raw)
To: Jassi Brar
Cc: Beleswar Padhi, Andrew Davis, Yuntao Dai, linux-kernel,
linux-acpi, mailbox, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
mailbox_client.h should be used by mailbox consumer drivers, not mailbox
controller (provider) drivers. The affected drivers do not use any mailbox
client APIs, so the include can be safely removed.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Changes in v2:
- Drop changes to pcc.c
- Update patch subject and commit log
- Link to v1: https://lore.kernel.org/r/20260127-mailbox-v1-v1-1-cf15d7cece48@nxp.com
---
drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
drivers/mailbox/cv1800-mailbox.c | 1 -
drivers/mailbox/omap-mailbox.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index 41f79e51d9e5a92089a3fd798e848d837fb2775a..5d278bb5a4c0635dfc46b4a6dc3addf0b3b5d1be 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -26,7 +26,6 @@
#include <linux/interrupt.h>
#include <linux/kernel.h>
#include <linux/mailbox_controller.h>
-#include <linux/mailbox_client.h>
#include <linux/mailbox/brcm-message.h>
#include <linux/module.h>
#include <linux/msi.h>
diff --git a/drivers/mailbox/cv1800-mailbox.c b/drivers/mailbox/cv1800-mailbox.c
index 4761191acf782654c1724df2c9cc619e1d7c985c..4bca9d8be4ba2c8debf6e48a5ddc2873f14b64fd 100644
--- a/drivers/mailbox/cv1800-mailbox.c
+++ b/drivers/mailbox/cv1800-mailbox.c
@@ -11,7 +11,6 @@
#include <linux/interrupt.h>
#include <linux/io.h>
#include <linux/kfifo.h>
-#include <linux/mailbox_client.h>
#include <linux/mailbox_controller.h>
#include <linux/module.h>
#include <linux/platform_device.h>
diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
index 17fe6545875d01606b80e678fca82bf44f6eaffa..d9f100c18895224cf323b073db93ce94d7e16d18 100644
--- a/drivers/mailbox/omap-mailbox.c
+++ b/drivers/mailbox/omap-mailbox.c
@@ -21,7 +21,6 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/mailbox_controller.h>
-#include <linux/mailbox_client.h>
#include "mailbox.h"
---
base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
change-id: 20260127-mailbox-v1-1461cd2955fe
Best regards,
--
Peng Fan <peng.fan@nxp.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers
2026-01-28 12:32 [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers Peng Fan (OSS)
@ 2026-01-28 12:48 ` Sudeep Holla
2026-01-29 6:10 ` lihuisong (C)
2026-02-02 0:55 ` Jassi Brar
1 sibling, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2026-01-28 12:48 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Jassi Brar, Beleswar Padhi, Andrew Davis, Yuntao Dai,
linux-kernel, linux-acpi, mailbox, Peng Fan
On Wed, Jan 28, 2026 at 08:32:10PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> mailbox_client.h should be used by mailbox consumer drivers, not mailbox
> controller (provider) drivers. The affected drivers do not use any mailbox
> client APIs, so the include can be safely removed.
>
Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers
2026-01-28 12:48 ` Sudeep Holla
@ 2026-01-29 6:10 ` lihuisong (C)
0 siblings, 0 replies; 4+ messages in thread
From: lihuisong (C) @ 2026-01-29 6:10 UTC (permalink / raw)
To: Sudeep Holla, Peng Fan (OSS)
Cc: Jassi Brar, Beleswar Padhi, Andrew Davis, Yuntao Dai,
linux-kernel, linux-acpi, mailbox, Peng Fan
On 1/28/2026 8:48 PM, Sudeep Holla wrote:
> On Wed, Jan 28, 2026 at 08:32:10PM +0800, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> mailbox_client.h should be used by mailbox consumer drivers, not mailbox
>> controller (provider) drivers. The affected drivers do not use any mailbox
>> client APIs, so the include can be safely removed.
>>
> Reviewed-by: Sudeep Holla <sudeep.holla@kernel.org>
LGTM,
Acked-by: lihuisong@huawei.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers
2026-01-28 12:32 [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers Peng Fan (OSS)
2026-01-28 12:48 ` Sudeep Holla
@ 2026-02-02 0:55 ` Jassi Brar
1 sibling, 0 replies; 4+ messages in thread
From: Jassi Brar @ 2026-02-02 0:55 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Beleswar Padhi, Andrew Davis, Yuntao Dai, linux-kernel,
linux-acpi, mailbox, Peng Fan
On Wed, Jan 28, 2026 at 6:32 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> mailbox_client.h should be used by mailbox consumer drivers, not mailbox
> controller (provider) drivers. The affected drivers do not use any mailbox
> client APIs, so the include can be safely removed.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in v2:
> - Drop changes to pcc.c
> - Update patch subject and commit log
> - Link to v1: https://lore.kernel.org/r/20260127-mailbox-v1-v1-1-cf15d7cece48@nxp.com
> ---
> drivers/mailbox/bcm-flexrm-mailbox.c | 1 -
> drivers/mailbox/cv1800-mailbox.c | 1 -
> drivers/mailbox/omap-mailbox.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index 41f79e51d9e5a92089a3fd798e848d837fb2775a..5d278bb5a4c0635dfc46b4a6dc3addf0b3b5d1be 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -26,7 +26,6 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/mailbox_controller.h>
> -#include <linux/mailbox_client.h>
> #include <linux/mailbox/brcm-message.h>
> #include <linux/module.h>
> #include <linux/msi.h>
> diff --git a/drivers/mailbox/cv1800-mailbox.c b/drivers/mailbox/cv1800-mailbox.c
> index 4761191acf782654c1724df2c9cc619e1d7c985c..4bca9d8be4ba2c8debf6e48a5ddc2873f14b64fd 100644
> --- a/drivers/mailbox/cv1800-mailbox.c
> +++ b/drivers/mailbox/cv1800-mailbox.c
> @@ -11,7 +11,6 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/kfifo.h>
> -#include <linux/mailbox_client.h>
> #include <linux/mailbox_controller.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
> index 17fe6545875d01606b80e678fca82bf44f6eaffa..d9f100c18895224cf323b073db93ce94d7e16d18 100644
> --- a/drivers/mailbox/omap-mailbox.c
> +++ b/drivers/mailbox/omap-mailbox.c
> @@ -21,7 +21,6 @@
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/mailbox_controller.h>
> -#include <linux/mailbox_client.h>
>
> #include "mailbox.h"
>
>
> ---
> base-commit: ca3a02fda4da8e2c1cb6baee5d72352e9e2cfaea
> change-id: 20260127-mailbox-v1-1461cd2955fe
>
> Best regards,
> --
> Peng Fan <peng.fan@nxp.com>
>
Applied to mailbox/for-next
Thanks
Jassi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-02 0:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 12:32 [PATCH v2] mailbox: Remove mailbox_client.h from controller drivers Peng Fan (OSS)
2026-01-28 12:48 ` Sudeep Holla
2026-01-29 6:10 ` lihuisong (C)
2026-02-02 0:55 ` Jassi Brar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox