From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2ABD366834; Tue, 24 Feb 2026 09:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771923945; cv=none; b=Xt4xrKau6yQ0/G9Fdtioo+Zs3z+VTxFgSw1PLut47SG7SYr2vvbUuQ0ItOMpcgQimnqc0j9hPLa9zkEGxoE6L5tgy1ta+dOap/YUnE/L0ePTF8RKNAfcVTevRFmH0efuNh4RjvNmYavDnGXQTR5jExHxIjYohvG/LijgwP1ZRtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771923945; c=relaxed/simple; bh=C6eDX850qudJZzZ/jP94djXo3aPCGTQw8yPmyNKOlS8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u0hALOyXNjuDlfe3RYRMkNCyYGCGUIYaVZaJNer+DK7bmMZPSju3VUqwYQyMh3bB/+wxeubjz4WH943+fPP9Jm7nBNzxH97sz6NIu1GOS3PNfngvjGhCwgt9dRKWARvAxhjqqL7+8l25fXiYxtsI8vM87OyYKLBlSLUMMtlo+A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SKUeI7bb; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SKUeI7bb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771923944; x=1803459944; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=C6eDX850qudJZzZ/jP94djXo3aPCGTQw8yPmyNKOlS8=; b=SKUeI7bbKS18Vh5Pxn3kBvQEr4SQYrIRN9tND3rtqkn1Z8HscdtUKSEb ztBFtzMEjGlOmVToSXvkR3jZW4Uei/iRuT7QlneonlRqdBSBkd8TQXfWT 0M4WFj8C7psLlgP0VAHnvyc1ivVv4aIYLvsIb6WE2W7u/rgE8YTJA9i/g nfWLNBTm+awFl8uMuXSUDrKzJ+gWpllI6zVgm+IQh4yvcFTjFwMf6p2Iy NBuE65Qg1OOmLMrji51CBVz2Rosggn6eqAFCLobKrhpnBjh7SbTdEGcnU +s/NybS0bcmDzjIAWUXwV/120yAHcbAtjnY7zxRKn32rbwc7sxxEYjjZU A==; X-CSE-ConnectionGUID: F4dunvGYTVW+E9NoQVuIUA== X-CSE-MsgGUID: yETdulGfRJ+/rG2njjd29w== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72843936" X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="72843936" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 01:05:43 -0800 X-CSE-ConnectionGUID: RBZVd6pGRyu088ozheeutA== X-CSE-MsgGUID: o3rXDO2HT3SBbEhQk2lvvQ== X-ExtLoop1: 1 Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.146]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 01:05:41 -0800 Date: Tue, 24 Feb 2026 11:05:38 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Zijun Hu , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, Greg Kroah-Hartman , Danilo Krummrich , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus Subject: Re: [PATCH v1 1/3] driver core: Split device data types to device/types.h Message-ID: References: <20260223204412.3298508-1-andriy.shevchenko@linux.intel.com> <20260223204412.3298508-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Feb 23, 2026 at 09:53:17PM +0100, Rafael J. Wysocki wrote: > On Mon, Feb 23, 2026 at 9:44 PM Andy Shevchenko > wrote: > > > > device.h is a huge header which is hard to follow and easy to miss > > something. Improve that by splitting device data types to device/types.h. > > > > In particular this helps to speedup the build of the code that includes > > device.h solely for a device data types. > > > > Signed-off-by: Andy Shevchenko > > But why do you want to move the struct device definition out of device.h? Because it's a data type, and we have many drivers that may require it (embed the struct device), but no device.h API is called directly — only via a certain framework). device.h also includes many unrelated headers in such a case. -- With Best Regards, Andy Shevchenko