From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D6BD337100; Mon, 23 Feb 2026 17:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869292; cv=none; b=JLtBm13skTC6uP3O65XRS5dCeO6r37GZQfwMa8pfIk/SNihWFEk6ILGWqnGMl3neyZicQ93l6Wl8/dKbXkh5Nu8OHHGXyg32fyopEbHcZn/1wA0dZ54GXAypeNANeUSImNlo0DdhJxk7UBeDZ/jRCgpi6RubEZ9qf4rvR9E3HSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771869292; c=relaxed/simple; bh=QNk9mwxIRZgCXMrxrgyvewByldxU4cf5Y9MIHnvZKM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GYBH6a99msztfGaox3XOXxrKPCzHQUCms3l0SN6OWlxaD6LnbH6VrhKulrjyTfGZQaI+SlzGBM5WJJsVFzkjO2cC4EoHSGTdU8KFNQKARdhzg/Oa8V5TRh0AaPlIc4E7RyQsyaX7D7DB8ftIP/VPoY8iXt6/qlzvmfvtac4XlsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=f8/1ZLLx; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="f8/1ZLLx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771869290; x=1803405290; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QNk9mwxIRZgCXMrxrgyvewByldxU4cf5Y9MIHnvZKM8=; b=f8/1ZLLxC2MUNOzdPxD15AQxHCHIn0eaoDrhZUTR7pNV8Etall2p+AN6 YXW6YtU/+pF5vHb/JX6HibdXUZ+/vatefhiWViPq1EPkOhUqUWj1qvyh0 CTeEoh6/Lbmy+hxb3nIUAI7ZydHigaJDuFqvdXjb3ZAre+/idt+R4C8Jm Ce3bwqjf5AFMKYbkX75z4+xxb104vGuXQxnOZWKvhzq28VHPl3xjNN14o 1e+2mjd6QD70Eo9QQMxkybgR1d0bT1LwwJ2xNyCU/TtehJX6rARjGriu6 4N6L6fXJHM7eZEQlUVaV6ocHIphXuw0ZaG5pfD6wkF8FsXWCKd2tav19P A==; X-CSE-ConnectionGUID: wugONLKgSJ2JLrB6DD0bnA== X-CSE-MsgGUID: oXCRxPgyRAm/8gHFuxOiaw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72575033" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="72575033" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:54:49 -0800 X-CSE-ConnectionGUID: HVN+B97CTPKV+ku3TafSVw== X-CSE-MsgGUID: sIQ5ThnORxicLsf7zTUfxg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="215657998" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.222]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:54:45 -0800 Date: Mon, 23 Feb 2026 19:54:43 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Linus Walleij , Bartosz Golaszewski , Dmitry Torokhov , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2 1/2] driver core: make fwnode_is_primary() public Message-ID: References: <20260223-device-match-secondary-fwnode-v2-0-966c00c9eeeb@oss.qualcomm.com> <20260223-device-match-secondary-fwnode-v2-1-966c00c9eeeb@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223-device-match-secondary-fwnode-v2-1-966c00c9eeeb@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Feb 23, 2026 at 04:40:52PM +0100, Bartosz Golaszewski wrote: > Export fwnode_is_primary() in fwnode.h for use in driver code. ... > --- a/include/linux/fwnode.h > +++ b/include/linux/fwnode.h > @@ -230,4 +230,9 @@ void fwnode_links_purge(struct fwnode_handle *fwnode); > void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode); > bool fw_devlink_is_strict(void); > > +static inline bool fwnode_is_primary(struct fwnode_handle *fwnode) > +{ > + return fwnode && !IS_ERR(fwnode->secondary); > +} This is inconsistent. Please, split out fwnode stuff from device.h to device/fwnode.h and share it there. This reminds me to look what I have locally in development... (With your patch it will be in device.h and fwnode.h and in the latter it's even not properly grouped with other non-fwdevlink related stuff.) -- With Best Regards, Andy Shevchenko