From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown Date: Wed, 6 Dec 2017 11:11:40 -0500 Message-ID: References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51240 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbdLFQLo (ORCPT ); Wed, 6 Dec 2017 11:11:44 -0500 In-Reply-To: Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Timur Tabi , "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List On 12/6/2017 9:57 AM, Sinan Kaya wrote: >> Yes, it should, so I'm not sure why you need the list in the first place. >> >> Also it looks like something along the lines of devres_release_all() >> should be sufficient. > Good suggestion, let me test this. > I tried to pull the code into GED but the API is not public. I also looked at how it is used. I was afraid to mess up with the internals of base.c by calling devres_release_all() externally first and by the driver framework next. I moved away from this approach. I just fixed the function rename and changed the dev_info() to dev_dbg(). -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.