From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Linux PM list <linux-pm@vger.kernel.org>,
linux-acpi@vger.kernel.org, lkp@01.org, x86@kernel.org
Cc: "Wanpeng Li" <wanpeng.li@hotmail.com>,
"Len Brown" <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Zhang Rui" <rui.zhang@intel.com>, "Chen Yu" <y.c.chen@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
jacob.jun.pan@intel.com, "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest
Date: Wed, 22 Jun 2016 19:43:15 +0200 [thread overview]
Message-ID: <aab33eba-e2d7-ff60-6a63-abee2a47cac8@redhat.com> (raw)
In-Reply-To: <1466558908-3524-1-git-send-email-wanpeng.li@hotmail.com>
On 22/06/2016 03:28, Wanpeng Li wrote:
>
> get_ratio:
> - rdmsr(MSR_PLATFORM_INFO, lo, hi);
> - ratio = (lo >> 8) & 0xff;
> + if (!rdmsr_safe(MSR_PLATFORM_INFO, &lo, &hi))
> + ratio = (lo >> 8) & 0xff;
This looks good, thanks.
Paolo
next prev parent reply other threads:[~2016-06-22 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 1:28 [PATCH] x86: fix rdmsr MSR_PLATFORM_INFO unsafe warning in kvm guest Wanpeng Li
2016-06-22 17:43 ` Paolo Bonzini [this message]
2016-06-23 7:09 ` Thomas Gleixner
2016-06-23 7:28 ` Wanpeng Li
2016-06-23 7:34 ` Wanpeng Li
2016-06-23 7:37 ` [LKP] " Yu Chen
2016-06-23 7:41 ` Wanpeng Li
2016-06-23 8:00 ` Wanpeng Li
2016-07-11 2:38 ` Wanpeng Li
2016-07-11 7:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aab33eba-e2d7-ff60-6a63-abee2a47cac8@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=rkrcmar@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
--cc=x86@kernel.org \
--cc=y.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).