From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5896F23183B; Sun, 29 Mar 2026 05:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774763911; cv=none; b=IEyN1HgdUL+KsHfrhgrJsoyIS2KIkKJPfGwZwDnVaXtkiRElJTonGIh1JTnpBTV/W00s2p2pqAn4ltWBByi97EVZoXRu/C1lR3yN5mN6LI3mR/Dt4eSJkTPkzZw3p/NY3LxPloxyipOUQ1rMNImY7Blm9zT8bXVSZLUvlgNn5yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774763911; c=relaxed/simple; bh=fojIAIARbeeLN70cfaOpPb/P7/PMERluDOhkJ8dJ6w0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XZmDFzeDMpJMuT1hao4XeveunuIUnZxAgzP06LDWiQ2kSpjVURpt05VoVtzZYsl0ovSV2GEsXhGDeabfsng780LWa4sqtvPYA1r4PbcRNC46W3OhQQxCUv21aQkRIWdGCwvWrO/M1QXxFqHIG+WjGOYuE/Suv+x5URSaE1RCbFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mxWl03Or; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mxWl03Or" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93A4DC116C6; Sun, 29 Mar 2026 05:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774763910; bh=fojIAIARbeeLN70cfaOpPb/P7/PMERluDOhkJ8dJ6w0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mxWl03Or51MD1rhCsEdjSAbEyQJ+RvZd9u5Lr4bX5ZjcFTqeJ7HLg/xrp1Vrzow22 2DOKkIqRJfEJXP2khwOlOR1ctiTddn12CMawF3Ji1kMZOPBERe3ex0wy6D8AkiF0lC ++DPORHpPV5N9JXoDDK/Y0GdIlUT6hUvbY4U58kPZ0PhaZXhTFBUHIM/TkgI/xILYy XgcQPIljE7w1THLhvykw+D2Tuy9jqEpBnL6y9L1KWL7ywgUJeWWUqUT/FNzJ6N6Z7B 7Q7VfWHGmvz/8JvAAK/fHsJkFOB8opMhjQF1G1o1fK+1g+9y4d1EmWHSuC36m1ACmj dMUd5kEZvZyOg== Date: Sat, 28 Mar 2026 22:58:28 -0700 From: Drew Fustini To: yunhui cui Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Radim =?utf-8?B?S3LEjW3DocWZ?= , Samuel Holland , Adrien Ricciardi , Nicolas Pitre , Kornel =?utf-8?Q?Dul=C4=99ba?= , Atish Patra , Atish Kumar Patra , Vasudevan Srinivasan , Ved Shanbhogue , Chen Pei , Liu Zhiwei , Weiwei Li , guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn, Reinette Chatre , Tony Luck , Babu Moger , Peter Newman , Fenghua Yu , James Morse , Ben Horgan , Dave Martin , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, Rob Herring , "Rafael J. Wysocki" , Len Brown , Robert Moore , Sunil V L , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [External] [PATCH RFC v2 06/17] RISC-V: QoS: define CBQRI resctrl resources and domains Message-ID: References: <20260128-ssqosid-cbqri-v2-0-dca586b091b9@kernel.org> <20260128-ssqosid-cbqri-v2-6-dca586b091b9@kernel.org> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Mar 26, 2026 at 04:32:47PM +0800, yunhui cui wrote: > Hi Drew， > > On Wed, Mar 25, 2026 at 2:49 PM Drew Fustini wrote: > > > > On Wed, Mar 25, 2026 at 10:31:39AM +0800, yunhui cui wrote: > > > Hi Drew, > > > > > > On Thu, Jan 29, 2026 at 4:28 AM Drew Fustini wrote: > > > > > > > > Define data structures to encapsulate the resctrl resource > > > > and domain structures. > > > > > > > > Co-developed-by: Adrien Ricciardi > > > > Signed-off-by: Adrien Ricciardi > > > > [fustini: rebased current upstream] > > > > Signed-off-by: Drew Fustini > > > > --- > > > > arch/riscv/kernel/qos/internal.h | 27 +++++++++++++++++++++++++++ > > > > 1 file changed, 27 insertions(+) > > > > > > > > diff --git a/arch/riscv/kernel/qos/internal.h b/arch/riscv/kernel/qos/internal.h > > > > index ff2c7eff50be..c0402dd06cfa 100644 > > > > --- a/arch/riscv/kernel/qos/internal.h > > > > +++ b/arch/riscv/kernel/qos/internal.h > > > > @@ -65,6 +65,11 @@ > > > > #define CBQRI_BC_ALLOC_CTL_OP_READ_LIMIT 2 > > > > #define CBQRI_BC_ALLOC_CTL_STATUS_SUCCESS 1 > > > > > > > > +int qos_resctrl_setup(void); > > > > +void qos_resctrl_exit(void); > > > > +int qos_resctrl_online_cpu(unsigned int cpu); > > > > +int qos_resctrl_offline_cpu(unsigned int cpu); > > > > + > > > > /* Capacity Controller hardware capabilities */ > > > > struct riscv_cbqri_capacity_caps { > > > > u16 ncblks; /* number of capacity blocks */ > > > > @@ -125,4 +130,26 @@ struct cbqri_controller { > > > > bool mon_capable; > > > > }; > > > > > > > > +struct cbqri_resctrl_res { > > > > + struct rdt_resource resctrl_res; > > > > + struct cbqri_controller controller; > > > > + u32 max_rcid; > > > > + u32 max_mcid; > > > > +}; > > > > + > > > > +struct cbqri_resctrl_dom { > > > > + struct rdt_domain_hdr resctrl_dom_hdr; > > > > + struct rdt_ctrl_domain resctrl_ctrl_dom; > > > > + struct rdt_mon_domain resctrl_mon_dom; > > > > + u64 cbm; > > > > + u64 rbwb; > > > > + u64 *ctrl_val; > > > > + struct cbqri_controller *hw_ctrl; > > > > +}; > > > > + > > > > > > Can we trim down some fields? For example: > > > struct cbqri_resctrl_res { > > > struct rdt_resource resctrl_res; > > > - struct cbqri_controller controller; > > > u32 max_rcid; > > > u32 max_mcid; > > > }; > > > > > > struct cbqri_resctrl_dom { > > > - struct rdt_domain_hdr resctrl_dom_hdr; > > > struct rdt_ctrl_domain resctrl_ctrl_dom; > > > struct rdt_mon_domain resctrl_mon_dom; > > > - u64 cbm; > > > - u64 rbwb; > > > u64 *ctrl_val; > > > struct cbqri_controller *hw_ctrl; > > > }; > > > > Can you explain why you don't think these are needed?? > > The functionality works well without those fields, feel free to try. Thanks for pointing this out. I have removed them. > Btw, when do you plan to send the next revision? The current branch is based on 6.19 so I need to rebase. I have addressesd most of the feedback so far except for tracking default closid/rmid for a cpu. I am thinking I should send a new version as it has been a long time and describe the open items that I have not solved yet. Thanks, Drew