From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31BC53A6B6A for ; Mon, 30 Mar 2026 21:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774907212; cv=none; b=Yp+ovwBHfV9EiHPI1YTP7SUeQ/rc/ik3QS9Xc8DzZH+wtRr/9kjQ6Pvr3Rveb00mAIVSwcD2uK/Cid7bFPENPm/4PI1XuhSAr9Kag3Fm6l+gMqHKZeiU1+11ARx7buwkFtoLmFORLUi6spFz61snu388ugu/U0qmJ0h8Zgj3SXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774907212; c=relaxed/simple; bh=H6TjEPdSZGIipXDhaHlw3GjgyD8b6HCnTcEmbY8Pw/c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hUWy2o159m4dHCxc22C7f4uqOZnahvUQzQqjEKK5yDC5iNZfcSJnMQgIm0LBkJBE9i6B32UU61drndM5V2VKiHFw7CdDfwpqpCy1ljDRLCa8Q0fJBfN6wRneGWfUuUMLMFldEJE9O/xp1Y8JTtuACtli588rS/D+9zv1fa1ZmFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DIIPSnF5; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DIIPSnF5" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2c6f5574d3cso519140eec.0 for ; Mon, 30 Mar 2026 14:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774907210; x=1775512010; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=y/4gRi5RHE4lEQNk8r3GZP5jsAjQXbbb0ZHPhMUySrM=; b=DIIPSnF5M6TJOXjmgABD26oMcLvEltvmnX/nc5atQExOQErENo8AJz4eSwwLhzbkjb ZrrUdvmWVOfwTEROGD8Nn+ktUwLj8OFElNWqxIDhwLpvC3Z1lCoMkexe/elFnX1R1kni t+Mt3Wv9O/sFFkH0HButc+y5m/DCxqtr3ZgYvtvXSD43gE5JIwDuzBBSkYjuHuwHLmXa 8zJVaR8xnjD4pNC+BxJ6Dzerese1rdIQ8e+cRUS1/jvGU31GCeWBAXgyWDeT26Ik3tGJ VdPB990Z8hU0Whvu0u9MrPn+drJyFqpG6bQHH93YRiJBVnDS5P1uK1tXa9LcSJuzENjl 7Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774907210; x=1775512010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y/4gRi5RHE4lEQNk8r3GZP5jsAjQXbbb0ZHPhMUySrM=; b=P4u57MfYWIeiUOXjPqeLt8gOE6yswciWHfQPw8dhcUrUpyQIXc3Ni639U/GpB3tMVU uP+QpUCeWqAnCHlBE122aBnjecGLCW+KwQ1Zi4UomtgI3X86wAsJ03ImgHM5yqTicT6B Thce6PROh9CUvpPtick0/EiKjVOrL8ZD4E9wKbz3yZoPPtJ2++LMbrClnSEyDUt55M6R 0wjPvQDP/R8Ge4ncIO2UI1VokYyEtpe6kHOy6BunMq6BfMkDbf3FDI4zbQPrnBsEFHNW M48Uhkzw3n3WsNMNOllnrdUHVBvjwo1ss0BPC110B6qxIaNtm6Wki09pBu+jJLwXnDxk 1Uow== X-Forwarded-Encrypted: i=1; AJvYcCU8ApjJADJde4zfOjKyzH3ouOc2y/pYukkXOIKtbrrfRlm0KT1Fz+wtS0htYhSmXetHDF3mrP3w7PLb@vger.kernel.org X-Gm-Message-State: AOJu0YxPRyAJ4Xk6Noub5v/vw8Zuwjh5dV8wO7sDpRN4LcQX+U8PFK5F RJASbVK0Vl/OXx4qW/5PxFikDRFgy/jUseL/a+VgKBAeywVyOog6XjIt X-Gm-Gg: ATEYQzxzCcu5yn5kdHGFzOl4POf2yhxRiZ/8/OMA/Cyf00ocXcLhV+zNzxzaZLFOtD4 Z3gtjwf+XZKksqTfopFpFNPC0dodfo6akOIbRp2pTP2HzpQMzKicJKn8LO9kWlzkbrD/58oPc5F lXNzB6RxJaqhLgh6aJmexsaRdi1ZQgemIWGlvjHvmBmrxeEO33qHifvHLqFqYerbEdKzOz5t/al kGU3E1s3PakOWLjztHA3ZkzjQNhN1MGNl7psTgQ5kvT/oFZ0028OgF/BcdqNcWbBUuVrJwsFzYn VCMY9VPomLQLg9hELVDs+zkX3ysgxaavTnKR68M/rrycViNVQdqrn/h860m3IxNvUxK6jtAUyrr k/EUSlX0Z2IWsFNFYQ/YrUtSHItZCCvGaeD5s/7f2qrSHNDxfgO1AUvsPNU5bc2bVZsFOkKvcBq rD5NoCqkgDSguAjW5X0AlI/IrsVpI+bX58VoHQ7LbIr3SMh7WecrEY0J3TFgze1Xb7 X-Received: by 2002:a05:7301:1f17:b0:2c5:d833:a507 with SMTP id 5a478bee46e88-2c7bc35b062mr700637eec.12.1774907210198; Mon, 30 Mar 2026 14:46:50 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:7f4e:2749:b37a:e9d5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c68b2721sm7751610eec.14.2026.03.30.14.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 14:46:49 -0700 (PDT) Date: Mon, 30 Mar 2026 14:46:45 -0700 From: Dmitry Torokhov To: Andy Shevchenko Cc: Bartosz Golaszewski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 2/3] driver core: make software nodes available earlier Message-ID: References: <20260330-nokia770-gpio-swnodes-v4-0-b68592e977d0@oss.qualcomm.com> <20260330-nokia770-gpio-swnodes-v4-2-b68592e977d0@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 30, 2026 at 11:24:45PM +0300, Andy Shevchenko wrote: > On Mon, Mar 30, 2026 at 02:40:47PM +0200, Bartosz Golaszewski wrote: > > Software nodes are currently initialized in a function registered as > > a postcore_initcall(). However, some devices may want to register > > software nodes earlier than that (or also in a postcore_initcall() where > > they're at the merci of the link order). Move the initialization to > > driver_init() making swnode available much earlier as well as making > > their initialization time deterministic. > > ... > > > -static void __exit software_node_exit(void) > > -{ > > - ida_destroy(&swnode_root_ids); > > - kset_unregister(swnode_kset); > > } > > -__exitcall(software_node_exit); > > > Why? What's wrong with the __exitcall? > It's dead code. Always was, always will be. Maybe split in a separate patch, but I sometimes feel the idea of "one change" is taken to extreme and adds to both developer's and maintainers burden by needing to keep track of extra patches. Thanks. -- Dmitry