Re: [PATCH v3] gpio: acpi: Call enable_irq_wake for _IAE GpioInts with Wake set

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 03/28/2017 03:23 PM, Linus Walleij wrote:
> On Fri, Mar 24, 2017 at 11:08 AM, Hans de Goede <hdegoede@redhat.com> wrote:
>
>> On Bay Trail / Cherry Trail systems with a LID switch, the LID switch is
>> often connect to a gpioint handled by an _IAE event handler.
>> Before this commit such systems would not wake up when opening the lid,
>> requiring the powerbutton to be pressed after opening the lid to wakeup.
>>
>> Note that Bay Trail / Cherry Trail systems use suspend-to-idle, so
>> the interrupts are generated anyway on those lines on lid switch changes,
>> but they are treated by the IRQ subsystem as spurious while suspended if
>> not marked as wakeup IRQs.
>>
>> This commit calls enable_irq_wake() for _IAE GpioInts with a valid
>> event handler which have their Wake flag set. This fixes such systems
>> not waking up when opening the lid.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>> ---
>> Changes in v2:
>> -Improve commit msg
>> -Add Mika's Acked-by
>> Changes in v3:
>> -Use irqd_is_wakeup_set rather then tracking this ourselves
>
> This looks like it should be applied for fixes and tagged for stable.

In theory this is a fix, but I'm afraid it may have undesirable
side-effects on some systems (I hope not but you never know) so I'm
not sure it should get tagged for stable, going into 4.11-rc# as
fix seems fine to me.

> Patch applied.

Thank you.

Regards,

Hans