From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7EF224DD15; Tue, 7 Apr 2026 07:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775545466; cv=none; b=ko43HtljLNroCe9TElndplzYY++FYeys9o0+TR6hdbOsNKtF9OnHYmYCdxP7ffxbmq2BCfmiWz099FvLtnfcD5ndr0dregXJdSy0YeZ/FfPXYM21qrEqXxdWGbm7NtC4QO0+mB/tF5cLcHBD+RXHx8cHVDaLw/u+29VGRgdFJ+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775545466; c=relaxed/simple; bh=Gjw9pVSfJyk8lGKR3YSdogwRldHB4JrnsplgXcwYkOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Smj2V+3wF6ZkF9xlH7DMGeTBSAECgB7FTjuS5df7EWe8pk+IOTpIW0AvNWNmD+Xxp2IczkTUOXvQjW8iuLYkBTyAMr59rU8ysKgyu8BNApLwfwmKK4MxhzP/t8m1kLtPJHEy+wuvncv1n4qsZhWMJMIAxNYGkD8if7S1vFpAkXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PI6nTNkq; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PI6nTNkq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775545465; x=1807081465; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Gjw9pVSfJyk8lGKR3YSdogwRldHB4JrnsplgXcwYkOg=; b=PI6nTNkq3/9bhWRVD9CUTOVPp8FX6dQlxysNiAxcilvqafVy8wCbJxgh AN/2LWCh7+FOIaEFeaEwP3BuQEDdRCZ0YbmmnN7vF20HeY1bvcnAhIxTy 2wuos2w9t7sA7OGZXWannhGCTRUXosEVPHnsD3xynZpOIvUvyt79U04bO jYvRqiimpcyqlEPpGUdgHHQh5+HNaXsWD8NkVSp8tMH1iN049IziXJ4+k 2K+4x0FgcfNd5+60SAGt15R7Q5Svrm5iaoJivc4WmwDaA/Xso12PX9Wx8 pCgzOCEog/SO5+9MRDU7yGdc2VDoCr3Nt/1KjQxbsFb04tYgRo68n2hVN w==; X-CSE-ConnectionGUID: eJKNYQvTQMy7ZY+eu6mE/A== X-CSE-MsgGUID: ARfPmcHmR02XoqpUWCOT6Q== X-IronPort-AV: E=McAfee;i="6800,10657,11751"; a="76382599" X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208";a="76382599" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 00:04:09 -0700 X-CSE-ConnectionGUID: ARjcj5YsSkOuSW/B4EXUQA== X-CSE-MsgGUID: qBWU+OS7SPqqGskJaINwjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208";a="223779891" Received: from amilburn-desk.amilburn-desk (HELO kekkonen.fi.intel.com) ([10.245.244.123]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 00:04:04 -0700 Received: from kekkonen.localdomain (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 19E3E12080D; Tue, 07 Apr 2026 10:04:18 +0300 (EEST) Date: Tue, 7 Apr 2026 10:04:18 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Bartosz Golaszewski Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mika Westerberg , Andy Shevchenko , Linus Walleij , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Dmitry Torokhov , Len Brown , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH v3 1/2] software node: return -ENOTCONN when referenced swnode is not registered yet Message-ID: References: <20260403-swnode-unreg-retcode-v3-0-7886092b28b4@oss.qualcomm.com> <20260403-swnode-unreg-retcode-v3-1-7886092b28b4@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403-swnode-unreg-retcode-v3-1-7886092b28b4@oss.qualcomm.com> Hi Bartosz, Thanks for the update. On Fri, Apr 03, 2026 at 03:51:50PM +0200, Bartosz Golaszewski wrote: > It's possible that at the time of resolving a reference to a remote > software node, the node we know exists is not yet registered as a full > firmware node. We currently return -ENOENT in this case but the same > error code is also returned in some other cases, like the reference > property with given name not existing in the property list of the local > software node. > > It makes sense to let users know that we're dealing with an unregistered > software node so that they can defer probe - the situation is somewhat > similar to there existing a firmware node to which no device is bound > yet - which is valid grounds for probe deferral. To that end: use > -ENOTCONN to indicate the software node is "not connected". > > Signed-off-by: Bartosz Golaszewski > --- > drivers/base/swnode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 51320837f3a9f1bf4f65aa161d9b941affc74936..61e73417aee89feb855b0f429e112ca0af78a003 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -554,7 +554,7 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, > return -EINVAL; > > if (!refnode) > - return -ENOENT; > + return -ENOTCONN; This needs to be documented for fwnode_property_get_reference_args() as well. In V4L2 we do so the caller just returns the error code but maybe that's not generic enough. > > if (nargs_prop) { > error = fwnode_property_read_u32(refnode, nargs_prop, &nargs_prop_val); > -- Kind regards, Sakari Ailus