Re: [PATCH v2 0/4] platform/x86: x86-android-tablets: use real firmware node references with intel drivers

Andy Shevchenko
2026-04-02T13:47:56Z

On Thu, Apr 02, 2026 at 03:35:24PM +0200, Bartosz Golaszewski wrote:
> On Thu, Apr 2, 2026 at 3:23 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > 3. Export the acpi_bus_type symbol. It's already available in the
> > > acpi_bus.h header but it's not available to loadable modules.
> >
> > Nowadays we don't do that but export the dev_is_acpi() or something similar if
> > it's not yet available and to_acpi_dev(). (Names are derived from the existing
> > pattern, they might be need to be adjusted, dunno.) See how PNP does that.
> > Note, I haven't read the patches yet, just a quick comment.
>
> Maybe I should have said why I do it. It's to register a notifier call
> on ACPI bus events. Is there a better way to do this?

AFAIU there shouldn't be pure ACPI devices, they are companions to the real
ones. Can we simply attach to the normal device notifier and check if the
companion is what we are looking for? Also since it's specific to that driver
and you know what the platforms you are looking for, why can't we hook
something into drivers/acpi/x86/lpss.c?

--
With Best Regards,
Andy Shevchenko