From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: rafael@kernel.org, lenb@kernel.org,
Andy Shevchenko <andy@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ACPI: pmic: Replace mutex_lock/unlock() with guard()/scoped_guard()
Date: Tue, 28 Apr 2026 11:13:56 +0300 [thread overview]
Message-ID: <afBsRD8KqszA6Ava@ashevche-desk.local> (raw)
In-Reply-To: <20260427231119.55486-1-m32285159@gmail.com>
On Mon, Apr 27, 2026 at 06:11:19PM -0500, Maxwell Doose wrote:
> Replace mutex_lock() and unlock() macros with the newer guard() and
> scoped_guard() macros. This will help modernize and clean the code.
>
> In intel_soc_pmic_exec_mipi_pmic_seq_element(): While at it, remove
> now redundant "ret" variable.
...
> - } else if (d->pmic_i2c_address) {
> - if (i2c_address == d->pmic_i2c_address) {
> - ret = regmap_update_bits(intel_pmic_opregion->regmap,
> - reg_address, mask, value);
> - } else {
> + if (d->pmic_i2c_address) {
> + if (i2c_address != d->pmic_i2c_address) {
I slightly tend to make this change less invasive, id est leaving the if-else
as it was in the original code.
...
> - __func__, i2c_address, reg_address, value, mask);
> + __func__, i2c_address, reg_address, value, mask);
Stray change.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-04-28 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 23:11 [PATCH v3] ACPI: pmic: Replace mutex_lock/unlock() with guard()/scoped_guard() Maxwell Doose
2026-04-28 8:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBsRD8KqszA6Ava@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=rafael@kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox