From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org,
Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] watchdog: ni903x_wdt: Check ACPI_COMPANION() against NULL
Date: Tue, 12 May 2026 19:46:56 +0300 [thread overview]
Message-ID: <agNZgKbjoxWjrMs3@ashevche-desk.local> (raw)
In-Reply-To: <2280455.irdbgypaU6@rafael.j.wysocki>
On Tue, May 12, 2026 at 06:22:57PM +0200, Rafael J. Wysocki wrote:
> Every platform driver can be forced to match a device that doesn't match
> its list of device IDs because of device_match_driver_override(), so
> platform drivers that rely on the existence of a device's ACPI companion
> object need to verify its presence.
>
> Accordingly, add a requisite ACPI_COMPANION() check against NULL to the
> ni903x_wdt watchdog driver.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
...
> - status = acpi_walk_resources(ACPI_HANDLE(dev), METHOD_NAME__CRS,
> + status = acpi_walk_resources(handle, METHOD_NAME__CRS,
> ni903x_resources, wdt);
This smells like we can move to regular acpi_dev_*() resource APIs rather than
custom walking via _CRS. But I haven't looked into the code.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-12 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 16:22 [PATCH v1] watchdog: ni903x_wdt: Check ACPI_COMPANION() against NULL Rafael J. Wysocki
2026-05-12 16:46 ` Andy Shevchenko [this message]
2026-05-12 18:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agNZgKbjoxWjrMs3@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox