From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Linux ACPI" <linux-acpi@vger.kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v1] platform/x86: xo15-ebook: Use devres-based resource management
Date: Wed, 13 May 2026 23:42:38 +0300 [thread overview]
Message-ID: <agTiPgeCEEbUEWEY@ashevche-desk.local> (raw)
In-Reply-To: <12913455.O9o76ZdvQC@rafael.j.wysocki>
On Wed, May 13, 2026 at 08:53:44PM +0200, Rafael J. Wysocki wrote:
> Use devm_kzalloc() and devm_input_allocate_device() in
> ebook_switch_probe() for allocating the button object and the
> input device, respectively, to simplify the rollback path in
> that function and ebook_switch_remove().
...
> id = acpi_match_acpi_device(ebook_device_ids, device);
> if (!id) {
> - dev_err(&pdev->dev, "Unsupported hid\n");
> - error = -ENODEV;
> - goto err_free_input;
> + dev_err(dev, "Unsupported hid\n");
> + return -ENODEV;
Now we can use
return dev_err_probe(dev, -ENODEV, "Unsupported hid\n");
> }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-13 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:53 [PATCH v1] platform/x86: xo15-ebook: Use devres-based resource management Rafael J. Wysocki
2026-05-13 20:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTiPgeCEEbUEWEY@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox