From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25C72360ECC; Tue, 23 Jun 2026 10:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209814; cv=none; b=Iuo5fDn8TMpy38xzZbqXg57kzyZnhu3+H9foe01E7SxP4rWYJfNShVMJ5jYbcBMKHa205TKScdYp6/lvckzDmfce4E+zp3q9/ytiAVeBX2n0ZC5HnYIehBKOlJrzGReKJ+JpkiASwXL2y8GXOQBx/JORipHxZ2ABWhZliHIY+1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209814; c=relaxed/simple; bh=6bKxg3mN3i5Bark5W9/mVCmbmllTCHZ+dsMNiE6JZKI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WBzc5aLyS8WRgPRyezAsSGGlrGZJLAophEdSlTETn0kTbcVGXKJKuswBCJ/TAwyWY7aAByCNUVqd2irygUqRhRgm/pEi7pXbEUYzGt13KUx1thVltnGv+h+yV3tOHlHfE5IRWJZEPSh/YBHr2khGbPY1YtRrcrcm/L4mHxJfOIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gPCo8moZ; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gPCo8moZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782209813; x=1813745813; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6bKxg3mN3i5Bark5W9/mVCmbmllTCHZ+dsMNiE6JZKI=; b=gPCo8moZHSBJcdIlrltZYTDeRSMK5+9zyO1qY20AzF/bpUx/8AsBviX2 d+fZQVDMj3skmScHVEC1mDGEWSfcjTW+pW79Es4y83LYDON7rgusJ3r/g F2v5fvPxdOroT/6BdxVA3tX3LBskIg66cDacoM4pnwZ4P4xiYMOyT7NWy Qim8IWKw+SxH22Tr0tT0+xC82Vfof+FhNemg7w2sob2zQdP+1jJDCcPPc v4Xm5kwBE10zCTYFBqOtC5Q6glmc4I7PvJ8c+U82L1heB0TYN2BvV4wlg N+9tvMUEXsdtZyd2lVczWd79i9hKQP/u6RDzV57dTN5KjbwBOCy5Dq8ET Q==; X-CSE-ConnectionGUID: DFzwMCrAQFWdMjiQo/mgsg== X-CSE-MsgGUID: wBE1A2G5TtWwKQixwj3SYw== X-IronPort-AV: E=McAfee;i="6800,10657,11825"; a="94064579" X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="94064579" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 03:16:52 -0700 X-CSE-ConnectionGUID: oBBWS6GuS0iUyF5cRmiQxg== X-CSE-MsgGUID: Ax1MZTXeQRWV89v3jlZ8VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="245121467" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.7]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2026 03:16:47 -0700 Date: Tue, 23 Jun 2026 13:16:45 +0300 From: Andy Shevchenko To: Frank.Li@oss.nxp.com Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Dafna Hirschfeld , Laurent Pinchart , Heiko Stuebner , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou , Frank Li Subject: Re: [PATCH 3/4] media: rkisp1: use fwnode_graph_for_each_endpoint_scoped() to simplify code Message-ID: References: <20260622-fw_scoped-v1-0-a37d0aac0a68@nxp.com> <20260622-fw_scoped-v1-3-a37d0aac0a68@nxp.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622-fw_scoped-v1-3-a37d0aac0a68@nxp.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jun 22, 2026 at 10:30:13AM -0400, Frank.Li@oss.nxp.com wrote: > Use fwnode_graph_for_each_endpoint_scoped() to simplify code. > > No functional changes. ... > - fwnode_graph_for_each_endpoint(fwnode, ep) { > + fwnode_graph_for_each_endpoint_scoped(fwnode, ep) { > struct fwnode_handle *port; > struct v4l2_fwnode_endpoint vep = { }; > struct rkisp1_sensor_async *rk_asd; > @@ -286,7 +285,6 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1) > } > > if (ret) { > - fwnode_handle_put(ep); > v4l2_async_nf_cleanup(ntf); > return ret; > } In this case you can go further and actually replace all the ret = -Exxx; break; with v4l2_async_nf_cleanup(ntf); return -Exx; in the above loop. but I assume the original is also fine as it's a common denominator for all of them (and only one case has something in addition to that). -- With Best Regards, Andy Shevchenko