Re: [PATCH v1 05/10] platform/x86: thinkpad_acpi: Stop setting acpi_device_class()

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Jul 03, 2026 at 01:30:00PM +0200, Rafael J.  Wysocki wrote:

> To facilitate the removal of device_class from struct acpi_device_pnp
> in the future, make the driver store the device class string used for
> generating ACPI netlink events in a new device_class field in struct
> ibm_struct.
> 
> No intentional functional impact.

...

>  		acpi_bus_generate_netlink_event(
> -					ibm->acpi->device->pnp.device_class,
> +					ibm->device_class,
>  					dev_name(&ibm->acpi->device->dev),
>  					event, 0);

In other cases you condensed the code a bit, not sure if you want to do the
similar here

		acpi_bus_generate_netlink_event(ibm->device_class,
						dev_name(&ibm->acpi->device->dev),
						event, 0);

>  		return;

...

>  		if (send_acpi_ev) {
>  			acpi_bus_generate_netlink_event(
> -					ibm->acpi->device->pnp.device_class,
> +					ibm->device_class,
>  					dev_name(&ibm->acpi->device->dev),
>  					event, hkey);
>  		}

Ditto.

-- 
With Best Regards,
Andy Shevchenko