From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-acpi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
driver-core@lists.linux.dev
Subject: Re: [PATCH] device property: add missing kernel-doc for property_entry
Date: Mon, 20 Jul 2026 14:51:29 +0300 [thread overview]
Message-ID: <al4LwVQ8aLSlP-dk@ashevche-desk.local> (raw)
In-Reply-To: <20260719223640.2864890-1-rdunlap@infradead.org>
On Sun, Jul 19, 2026 at 03:36:40PM -0700, Randy Dunlap wrote:
> Add kernel-doc for the missing fields in union value:
>
> Warning: include/linux/property.h:406 struct member 'u8_data' not
> described in 'property_entry'
> Warning: include/linux/property.h:406 struct member 'u16_data' not
> described in 'property_entry'
> Warning: include/linux/property.h:406 struct member 'u32_data' not
> described in 'property_entry'
> Warning: include/linux/property.h:406 struct member 'u64_data' not
> described in 'property_entry'
> Warning: include/linux/property.h:406 struct member 'str' not described
> in 'property_entry'
...
> * @pointer: Pointer to the property when it is not stored inline.
> * @value: Value of the property when it is stored inline.
> + * @u8_data: @value as an array of u8 numbers
> + * @u16_data: @value as an array of u16 numbers
> + * @u32_data: @value as an array of u32 numbers
> + * @u64_data: @value as an array of u64 numbers
> + * @str: @value as an array of char pointers
I think the proper fix is to add
/* private: internal representation of @value */
> */
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-20 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 22:36 [PATCH] device property: add missing kernel-doc for property_entry Randy Dunlap
2026-07-20 6:22 ` Sakari Ailus
2026-07-20 11:51 ` Andy Shevchenko [this message]
2026-07-20 15:30 ` Randy Dunlap
2026-07-20 19:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4LwVQ8aLSlP-dk@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=dakr@kernel.org \
--cc=djrscally@gmail.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox