From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 09/20] gpio: Add missing dmi module annotations
Date: Tue, 14 Jul 2026 11:36:06 +0300 [thread overview]
Message-ID: <alX09v_juWEZs7TC@ashevche-desk.local> (raw)
In-Reply-To: <alXyEPWUS5cJg6Jb@ashevche-desk.local>
On Tue, Jul 14, 2026 at 11:23:48AM +0300, Andy Shevchenko wrote:
> On Tue, Jul 14, 2026 at 09:24:10AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > A driver module matching devices using an dmi device id table is
> > supposed to declare that in the module's metadata. Add this information
> > for two drivers that failed to declare these.
>
> No, it is not supposed. Why?
...
> These are quirks and enumerating by quirks sounds weird.
Saying that I recall that we have also PCI ID tables and ACPI for the other
purposes than enumeration. Please, revisit all your patches with the same idea
and remove those MODULE_DEVICE_TABLE():s which are not required or actually
must not be there. Some drivers have comments regarding to the absence of the
macro, but some may not. Feel free to add a comment there.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-14 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 7:24 [PATCH v1 00/20] gpio: Improvements around device-id arrays Uwe Kleine-König (The Capable Hub)
2026-07-14 7:24 ` [PATCH v1 09/20] gpio: Add missing dmi module annotations Uwe Kleine-König (The Capable Hub)
2026-07-14 8:23 ` Andy Shevchenko
2026-07-14 8:36 ` Andy Shevchenko [this message]
2026-07-14 7:24 ` [PATCH v1 20/20] gpio: Unify style of various *_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-14 8:10 ` Viresh Kumar
2026-07-14 8:12 ` Sakari Ailus
2026-07-14 8:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alX09v_juWEZs7TC@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox