Re: [Patch V4 11/42] x86, ioapic: kill unused global variable timer_through_8259

Jiang Liu
2014-06-10T03:21:04Z

On 2014/6/9 22:41, Maciej W. Rozycki wrote:
> On Mon, 9 Jun 2014, Jiang Liu wrote:
>
>> index d4aba16e6bbf..94a56c233e87 100644
>> --- a/arch/x86/kernel/apic/io_apic.c
>> +++ b/arch/x86/kernel/apic/io_apic.c
>> @@ -2638,8 +2638,6 @@ static int __init disable_timer_pin_setup(char *arg)
>> }
>> early_param("disable_timer_pin_1", disable_timer_pin_setup);
>>
>> -int timer_through_8259 __initdata;
>> -
>> /*
>> * This code may look a bit paranoid, but it's supposed to cooperate with
>> * a wide range of boards and BIOS bugs. Fortunately only the timer IRQ
>> @@ -2744,7 +2742,6 @@ static inline void __init check_timer(void)
>> legacy_pic->unmask(0);
>> if (timer_irq_works()) {
>> apic_printk(APIC_QUIET, KERN_INFO "....... works.\n");
>> - timer_through_8259 = 1;
>> goto out;
>> }
>> /*
>
> So how does the new NMI watchdog handle systems that use this '8259A
> Virtual Wire' mode, pretty common on pre-P6 computers?
Hi Maciej,
We just kill the useless variable "timer_through_8259", 8259 virtual
wire mode is still supported.
Thanks!
Gerry

>
> Maciej
>