Re: [Bugfix] x86, irq: Fix bug in setting IOAPIC pin attributes

Randy Dunlap
2014-08-26T18:55:58Z

On 08/26/14 01:45, Jiang Liu wrote:
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 29290f554e79..66c2700c9f83 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -3896,7 +3896,15 @@ int mp_irqdomain_map(struct irq_domain *domain, unsigned int virq,
> + /*
> + * setup_IO_APIC_irqs() programs all legacy IRQs with default
> + * trigger and polarity attirbutes. Don't set the flag for that

attributes.

> + * case so the first legacy IRQ user could reprogram the pin
> + * with real trigger and polarity attributes.
> + */

thanks,
--
~Randy