From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [RFC Part1 v1 07/18] x86, irq: Introduce helpers to access struct irq_cfg Date: Thu, 11 Sep 2014 16:47:26 +0200 (CEST) Message-ID: References: <1410423905-26239-1-git-send-email-jiang.liu@linux.intel.com> <1410423905-26239-8-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from www.linutronix.de ([62.245.132.108]:41048 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbaIKOsK (ORCPT ); Thu, 11 Sep 2014 10:48:10 -0400 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiang Liu Cc: Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , Borislav Petkov , Grant Likely , Konrad Rzeszutek Wilk , Andrew Morton , Tony Luck , Joerg Roedel , Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org On Thu, 11 Sep 2014, Thomas Gleixner wrote: > On Thu, 11 Sep 2014, Jiang Liu wrote: > > -static inline struct irq_cfg *irq_cfg(unsigned int irq) > > +struct irq_cfg *irq_cfg(unsigned int irq) > > { > > return irq_get_chip_data(irq); > > } > > > > +struct irq_cfg *irqd_cfg(struct irq_data *irq_data) > > +{ > > + return irq_data->chip_data; > > +} > > We can make those inlines. There is no point to have that as global > functions. Never mind. Just reading the other patch set.....