From: Thomas Gleixner <tglx@linutronix.de>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Yinghai Lu" <yinghai@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Tony Luck" <tony.luck@intel.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger
Subject: Re: [RFC v1 11/11] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked()
Date: Fri, 15 May 2015 22:48:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1505152247280.4225@nanos> (raw)
In-Reply-To: <1430709339-29083-12-git-send-email-jiang.liu@linux.intel.com>
On Mon, 4 May 2015, Jiang Liu wrote:
> /* caller has locked the irq_desc and both params are valid */
> static inline void
> -__irq_set_chip_handler_name_locked(unsigned int irq, struct irq_chip *chip,
> +__irq_set_chip_handler_name_locked(struct irq_data *data, struct irq_chip *chip,
> irq_flow_handler_t handler, const char *name)
> {
> struct irq_desc *desc;
>
> - desc = irq_to_desc(irq);
> - irq_desc_get_irq_data(desc)->chip = chip;
> + desc = irq_to_desc(data->irq);
We should have a irq_data_to_desc() helper and use that instead of
going through a full lookup again.
Thanks,
tglx
next prev parent reply other threads:[~2015-05-15 20:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 3:15 [RFC v1 00/11] Split struct irq_data into common part and per-chip part Jiang Liu
2015-05-04 3:15 ` [RFC v1 01/11] genirq: Introduce struct irq_common_data to host shared irq data Jiang Liu
2015-05-08 2:23 ` Yun Wu (Abel)
2015-05-18 2:58 ` Jiang Liu
2015-05-04 3:15 ` [RFC v1 02/11] genirq: Move field 'node' from struct irq_data into struct irq_common_data Jiang Liu
2015-05-08 2:29 ` Yun Wu (Abel)
2015-05-08 3:04 ` Yun Wu (Abel)
2015-05-15 20:42 ` Thomas Gleixner
2015-05-04 3:15 ` [RFC v1 03/11] genirq: Use CONFIG_NUMA instead of CONFIG_SMP to guard irq_common_data.node Jiang Liu
2015-05-15 20:44 ` Thomas Gleixner
2015-05-18 5:17 ` Jiang Liu
2015-05-04 3:15 ` [RFC v1 04/11] genirq: Move field 'handler_data' from struct irq_data into struct irq_common_data Jiang Liu
2015-05-04 3:15 ` [RFC v1 05/11] mn10300: Fix incorrect use of data->affinity Jiang Liu
2015-05-04 3:15 ` [RFC v1 06/11] genirq: Introduce helper function irq_data_get_affinity_mask() Jiang Liu
2015-05-04 3:15 ` [RFC v1 07/11] net/mlx4: Cache irq_desc->affinity instead of irq_desc Jiang Liu
2015-05-04 12:10 ` Amir Vadai
2015-05-04 14:00 ` Jiang Liu
2015-05-05 9:07 ` Amir Vadai
2015-05-04 15:10 ` Thomas Gleixner
2015-05-05 9:17 ` Amir Vadai
2015-05-05 14:53 ` Thomas Gleixner
2015-05-07 10:41 ` Amir Vadai
2015-05-04 3:15 ` [RFC v1 08/11] genirq: Move field 'affinity' from struct irq_data into struct irq_common_data Jiang Liu
2015-05-04 3:15 ` [RFC v1 09/11] genirq: Use helper function to access irq_data->msi_desc Jiang Liu
2015-05-04 3:15 ` [RFC v1 10/11] genirq: Move field 'msi_desc' from struct irq_data into struct irq_common_data Jiang Liu
2015-05-04 3:15 ` [RFC v1 11/11] genirq: Pass irq_data to helper function __irq_set_chip_handler_name_locked() Jiang Liu
2015-05-15 20:48 ` Thomas Gleixner [this message]
2015-05-15 20:57 ` [RFC v1 00/11] Split struct irq_data into common part and per-chip part Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1505152247280.4225@nanos \
--to=tglx@linutronix.de \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=gnurou@gmail.com \
--cc=hpa@zytor.com \
--cc=james.hogan@imgtec.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=marc.zyngier@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rdunlap@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=soren.brinkmann@xilinx.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox