From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
rjw@rjwysocki.net, lenb@kernel.org, izumi.taku@jp.fujitsu.com,
wency@cn.fujitsu.com, caoj.fnst@cn.fujitsu.com,
ddaney.cavm@gmail.com, okaya@codeaurora.org, bhelgaas@google.com,
jiang.liu@linux.intel.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] pci: fix unavailable irq number 255 reported by BIOS
Date: Tue, 26 Jan 2016 10:51:56 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1601261049540.3886@nanos> (raw)
In-Reply-To: <56A7404A.8080205@cn.fujitsu.com>
On Tue, 26 Jan 2016, Chen Fan wrote:
> On 01/26/2016 04:26 PM, Thomas Gleixner wrote:
> > > > if (gsi < 0) {
> > > > - if (acpi_isa_register_gsi(dev))
> > > > +#ifdef CONFIG_X86
> > > > + /*
> > > > + * The Interrupt Line value of 0xff is defined to mean
> > > > "unknown"
> > > > + * or "no connection" (PCI 3.0, Section 6.2.4, footnote on
> > > > page
> > > > + * 223), using ~0U as invalid IRQ.
> > > > + */
> > And why would this be x86 specific? PCI3.0 is architecture independent,
> > right?
> quoting the spec document:
> "For x86 based PCs, the values in this register correspond to IRQ numbers
> (0-15) of the standard dual
> 8259 configuration. The value 255 is defined as meaning "unknown" or "no
> connection" to the interrupt
> controller. Values between 15 and 254 are reserved."
So if that is x86 specific then it needs to be documented proper. The fact
that the comment is inside the #ifdef x86 does not tell.
Thanks,
tglx
next prev parent reply other threads:[~2016-01-26 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 6:59 [PATCH v2] pci: fix unavailable irq number 255 reported by BIOS Chen Fan
2016-01-25 20:58 ` Bjorn Helgaas
2016-01-26 1:40 ` Chen Fan
2016-01-26 4:05 ` Guenter Roeck
2016-01-26 8:26 ` Thomas Gleixner
2016-01-26 9:45 ` Chen Fan
2016-01-26 9:51 ` Thomas Gleixner [this message]
2016-01-26 15:22 ` Bjorn Helgaas
2016-01-26 15:48 ` Thomas Gleixner
2016-01-27 0:25 ` Bjorn Helgaas
2016-01-27 5:24 ` Cao jin
2016-01-27 8:35 ` Thomas Gleixner
2016-01-27 9:13 ` Thomas Gleixner
2016-01-27 22:32 ` Bjorn Helgaas
2016-01-28 1:00 ` Chen Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1601261049540.3886@nanos \
--to=tglx@linutronix.de \
--cc=bhelgaas@google.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=ddaney.cavm@gmail.com \
--cc=helgaas@kernel.org \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox