From: Thomas Gleixner <tglx@linutronix.de>
To: Fu Wei <fu.wei@linaro.org>
Cc: linaro-acpi@lists.linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, rruigrok@codeaurora.org, wim@iguana.be,
wei@redhat.com, lorenzo.pieralisi@arm.com, al.stone@linaro.org,
timur@codeaurora.org, daniel.lezcano@linaro.org,
linux-acpi@vger.kernel.org, linux@roeck-us.net, lenb@kernel.org,
harba@codeaurora.org, linux-watchdog@vger.kernel.org,
arnd@arndb.de, marc.zyngier@arm.com, jcm@redhat.com,
cov@codeaurora.org, linux-arm-kernel@lists.infradead.org,
graeme.gregory@linaro.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, leo.duran@amd.com,
hanjun.guo@linaro.org, Suravee.Suthikulpanit@amd.com,
sudeep.holla@arm.com
Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.
Date: Tue, 6 Sep 2016 16:36:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1609061635000.5647@nanos> (raw)
In-Reply-To: <1473168352-5156-6-git-send-email-fu.wei@linaro.org>
On Tue, 6 Sep 2016, fu.wei@linaro.org wrote:
> + if (timer_count < 0)
> + pr_err("Failed to get platform timer info, skipping.\n");
So this prints something about skipping. But then it continues as if
nothing went wrong. That's either wrong or confusing or both.
> - arch_timer_init();
> - return 0;
> + return arch_timer_init();
Thanks,
tglx
next prev parent reply other threads:[~2016-09-06 14:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:25 [PATCH v11 0/8] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei
2016-09-06 13:25 ` [PATCH v11 1/8] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei
2016-09-06 13:25 ` [PATCH v11 2/8] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei
2016-09-06 13:25 ` [PATCH v11 3/8] clocksource/drivers/arm_arch_timer: Improve printk relevant code fu.wei
2016-09-06 13:25 ` [PATCH v11 4/8] acpi/arm64: Add GTDT table parse driver fu.wei
2016-09-06 13:25 ` [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei
2016-09-06 14:36 ` Thomas Gleixner [this message]
2016-09-07 9:23 ` Fu Wei
2016-09-13 9:22 ` Fu Wei
2016-09-13 10:21 ` Fu Wei
2016-09-13 11:38 ` Timur Tabi
[not found] ` <57D7E543.3060301-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-13 11:51 ` Fu Wei
2016-09-06 13:25 ` [PATCH v11 6/8] acpi/arm64: Add memory-mapped timer support in GTDT driver fu.wei
2016-09-06 13:25 ` [PATCH v11 7/8] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei
2016-09-13 10:49 ` Marc Zyngier
2016-09-06 13:25 ` [PATCH v11 8/8] acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver fu.wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1609061635000.5647@nanos \
--to=tglx@linutronix.de \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=graeme.gregory@linaro.org \
--cc=hanjun.guo@linaro.org \
--cc=harba@codeaurora.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=leo.duran@amd.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rruigrok@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=timur@codeaurora.org \
--cc=wei@redhat.com \
--cc=will.deacon@arm.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox