From: Thomas Gleixner <tglx@linutronix.de>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net,
bhelgaas@google.com, ravikanth.nalla@hpe.com,
linux@rainbow-software.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com,
linux-pci@vger.kernel.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wim@djo.tudelft.nl,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"
Date: Tue, 4 Oct 2016 09:23:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610040919110.5278@nanos> (raw)
In-Reply-To: <1475343976-20744-3-git-send-email-okaya@codeaurora.org>
On Sat, 1 Oct 2016, Sinan Kaya wrote:
> This reverts commit 9e5ed6d1fb87 ("ACPI,PCI,IRQ: remove SCI penalize
> function"). SCI penalty API was replaced by the runtime penalty calculation
> based on the value of acpi_gbl_FADT.sci_interrupt.
This does more than only reverting said commit ....
> acpi_gbl_FADT.sci_interrupt type does not get updated at the right time
> for some platforms and results in incorrect penalty assignment for PCI
> IRQs as irq_get_trigger_type returns the wrong type.
And the obvious question is: Why does irq_get_trigger_type() return the
wrong type?
What's the root cause of this problem? Your changelog does not tell
anything.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-04 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 17:46 [PATCH 1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16" Sinan Kaya
2016-10-01 17:46 ` [PATCH 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts Sinan Kaya
2016-10-02 11:40 ` [2/3] " Jonathan Liu
2016-10-01 17:46 ` [PATCH 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function" Sinan Kaya
2016-10-02 11:40 ` [3/3] " Jonathan Liu
2016-10-04 7:23 ` Thomas Gleixner [this message]
2016-10-04 14:10 ` [PATCH 3/3] " Sinan Kaya
2016-10-04 14:23 ` Thomas Gleixner
2016-10-02 11:40 ` [1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16" Jonathan Liu
2016-10-03 1:07 ` Sinan Kaya
2016-10-03 8:03 ` Jonathan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610040919110.5278@nanos \
--to=tglx@linutronix.de \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=cov@codeaurora.org \
--cc=hpa@zytor.com \
--cc=jcm@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=mingo@redhat.com \
--cc=okaya@codeaurora.org \
--cc=pavel@ucw.cz \
--cc=ravikanth.nalla@hpe.com \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
--cc=wim@djo.tudelft.nl \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox