Re: [patch (for 2.6.26?) 2/2] acpi: fix drivers/acpi/glue.c build error

[Len Brown <lenb@kernel.org>]

On Mon, 9 Jun 2008, akpm@linux-foundation.org wrote:

> From: Ingo Molnar <mingo@elte.hu>
> 
> x86.git testing found the following build bug:
> 
>   drivers/built-in.o: In function `acpi_rtc_init':
>   glue.c:(.init.text+0x16c3): undefined reference to `pnp_bus_type'
> 
> this tries to use PNP bus infrastructure even in the !PNP case.
> 
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/acpi/glue.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff -puN drivers/acpi/glue.c~acpi-fix-drivers-acpi-gluec-build-error drivers/acpi/glue.c
> --- a/drivers/acpi/glue.c~acpi-fix-drivers-acpi-gluec-build-error
> +++ a/drivers/acpi/glue.c
> @@ -303,6 +303,7 @@ static void rtc_wake_off(struct device *
>  
>  static struct cmos_rtc_board_info rtc_info;
>  
> +#ifdef CONFIG_PNP
>  
>  /* PNP devices are registered in a subsys_initcall();
>   * ACPI specifies the PNP IDs to use.
> @@ -364,4 +365,6 @@ static int __init acpi_rtc_init(void)
>  /* do this between RTC subsys_initcall() and rtc_cmos driver_initcall() */
>  fs_initcall(acpi_rtc_init);
>  
> +#endif /* CONFIG_PNP */
> +
>  #endif

ENOREPRODUCE

I'm unable to convince "make oldconfig" to allow a
CONFIG_ACPI=y CONFIG_PNP=n build.

-Len