Linux ACPI
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: louisqi <louisqi@viatech.com.cn>, Ingo Molnar <mingo@elte.hu>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH] ACPI: Add _PDC object evaluate for VIA.
Date: Wed, 08 Oct 2008 20:46:57 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0810082037340.3041@localhost.localdomain> (raw)
In-Reply-To: <7E82351C108FA840AB1866AC776AEC463775879E@orsmsx505.amr.corp.intel.com>



> Question: Where are these PDC bits defined for via CPUs? I mean the bits that we use in intel_pdc are
> defined in an Intel specific document. Just wondering whether the same bit definitions hold good for
> via or we should have a different set of defines?

ditto.
init_intel_pdc() uses Intel vendor specific bits documented in 
ftp://download.intel.com/technology/IAPC/acpi/downloads/30222305.pdf
and coded into include/acpi/pdc_intel.h

If VIA is going to have any different bit definitions, then
we should really create a pdc_via.h.  But if VIA is going to re-use
the bits defined by Intel in a compatible way for the
forseeable future, then probably all we need to do is add a
comment saying that the bits VIA is using have the exact
same meaning as they do for Intel.

thanks,
-Len

ps. I'm delighted to receive a patch from VIA.
Sometimes we run into failures in undocumented VIA chipsets,
perhaps you can help us when we run into those?

      reply	other threads:[~2008-10-09  0:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-27  8:52 [PATCH] ACPI: Add _PDC object evaluate for VIA louisqi
2008-09-27 16:05 ` Ingo Molnar
2008-09-28  2:40   ` louisqi
2008-10-08  2:19     ` louisqi
2008-10-08 23:47       ` Pallipadi, Venkatesh
2008-10-09  0:46         ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0810082037340.3041@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=louisqi@viatech.com.cn \
    --cc=mingo@elte.hu \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox