From mboxrd@z Thu Jan 1 00:00:00 1970 From: Len Brown Subject: RE: [PATCH] Subject: Prevent acpi_run_osc from using NULL objects (was: Re: Oops in ACPI with git latest) Date: Fri, 24 Oct 2008 16:27:05 -0400 (EDT) Message-ID: References: <1224791103.3330.37.camel@localhost.localdomain> <1224811642.3330.57.camel@localhost.localdomain> <200810240857.18190.rjw@sisk.pl> <200810241349.43166.rjw@sisk.pl> <4911F71203A09E4D9981D27F9D8308580AA7FA4F@orsmsx503.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from vms173005pub.verizon.net ([206.46.173.5]:61208 "EHLO vms173005pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbYJXU1U (ORCPT ); Fri, 24 Oct 2008 16:27:20 -0400 In-reply-to: <4911F71203A09E4D9981D27F9D8308580AA7FA4F@orsmsx503.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Moore, Robert" Cc: "Rafael J. Wysocki" , James Bottomley , Jesse Barnes , "linux-acpi@vger.kernel.org" , linux-kernel > We've just recently deployed a new module that validates the inputs and outputs > for the predefined ACPI methods (Those that start with underscore). > > That is the source of these messages: > > > > ACPI Warning (nspredef-0252): \_SB_.PCI0._OSC: Parameter count mismatch - ASL declared 5, expected 4 [20080926] > > > ACPI Error (nspredef-0163): \_SB_.PCI0._OSC: Missing expected return value [20080926] > > For the initial version of this module, we only output messages when the inputs and/or > outputs don't match the requirements of the ACPI specification. > > We can change this to returning exceptions in the future. I expect we're going to have a bunch of false positives with this one, and indeed may need to even pare the warnings back to only when CONFIG_ACPI_DEBUG, or acpi=strict or something. -Len