From: Len Brown <lenb@kernel.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-acpi@vger.kernel.org, Zhao Yakui <yakui.zhao@intel.com>,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: Re: [PATCH 02/11] ACPI: remove comments about debug layer/level to use
Date: Thu, 06 Nov 2008 15:30:30 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0811061530240.3106@localhost.localdomain> (raw)
In-Reply-To: <20081105231742.26131.76623.stgit@bob.kio>
applied.
thanks,
-len
On Wed, 5 Nov 2008, Bjorn Helgaas wrote:
> I don't think there's any point in cluttering the code with these.
> Better to improve the documentation so *anybody* can figure out
> what layer & level to use.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
> drivers/acpi/pci_root.c | 6 ------
> drivers/acpi/video.c | 6 ------
> 2 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index 1b8f67d..642554b 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -376,15 +376,9 @@ static int acpi_pci_root_remove(struct acpi_device *device, int type)
>
> static int __init acpi_pci_root_init(void)
> {
> -
> if (acpi_pci_disabled)
> return 0;
>
> - /* DEBUG:
> - acpi_dbg_layer = ACPI_PCI_COMPONENT;
> - acpi_dbg_level = 0xFFFFFFFF;
> - */
> -
> if (acpi_bus_register_driver(&acpi_pci_root_driver) < 0)
> return -ENODEV;
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index a29b0cc..bf0c26a 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -2094,12 +2094,6 @@ static int __init acpi_video_init(void)
> {
> int result = 0;
>
> -
> - /*
> - acpi_dbg_level = 0xFFFFFFFF;
> - acpi_dbg_layer = 0x08000000;
> - */
> -
> acpi_video_dir = proc_mkdir(ACPI_VIDEO_CLASS, acpi_root_dir);
> if (!acpi_video_dir)
> return -ENODEV;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-11-06 20:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 23:17 [PATCH 00/11] RFC: various ACPI core cleanups Bjorn Helgaas
2008-11-05 23:17 ` [PATCH 01/11] ACPI: update debug parameter documentation Bjorn Helgaas
2008-11-06 20:29 ` Len Brown
2008-11-06 21:22 ` Bjorn Helgaas
2008-11-06 22:15 ` Len Brown
2008-11-06 22:24 ` Randy Dunlap
2008-11-05 23:17 ` [PATCH 02/11] ACPI: remove comments about debug layer/level to use Bjorn Helgaas
2008-11-06 20:30 ` Len Brown [this message]
2008-11-05 23:17 ` [PATCH 03/11] ACPI: SBS: remove useless acpi_cm_sbs_init() initcall Bjorn Helgaas
2008-11-06 20:31 ` Len Brown
2008-11-05 23:17 ` [PATCH 04/11] ACPI: pci_link: remove acpi_irq_balance_set() interface Bjorn Helgaas
2008-11-06 20:41 ` Len Brown
2008-11-05 23:17 ` [PATCH 05/11] ACPI: remove CONFIG_ACPI_POWER Bjorn Helgaas
2008-11-06 20:42 ` Len Brown
2008-11-05 23:18 ` [PATCH 06/11] ACPI: remove CONFIG_ACPI_EC Bjorn Helgaas
2008-11-06 20:57 ` Len Brown
2008-11-05 23:18 ` [PATCH 07/11] ACPI: add CONFIG_ACPI_PCI Bjorn Helgaas
2008-11-06 19:41 ` Bjorn Helgaas
2008-11-05 23:18 ` [PATCH 08/11] ACPI: remove ACPI dependency on PCI Bjorn Helgaas
2008-11-05 23:18 ` [PATCH 09/11] ACPI: remove ACPI dependency on PM Bjorn Helgaas
2008-11-05 23:18 ` [PATCH 10/11] ia64: remove automatic PM selection Bjorn Helgaas
2008-11-05 23:18 ` [PATCH 11/11] ACPI: call core init functions explicitly instead of using initcalls Bjorn Helgaas
2008-11-06 22:02 ` Len Brown
2008-11-06 23:40 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0811061530240.3106@localhost.localdomain \
--to=lenb@kernel.org \
--cc=astarikovskiy@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox